Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup

2013-06-10 Thread Peter Crosthwaite
Hi Andreas, On Mon, Jun 10, 2013 at 9:49 PM, Andreas Färber wrote: > Am 10.06.2013 12:23, schrieb Peter Crosthwaite: >> Ping! >> >> Any objections to this one going in? perhaps even via trivial queue? > > No strong objection, but you are using an unusual 12-char indentation in > some places that

Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup

2013-06-10 Thread Andreas Färber
Am 10.06.2013 12:23, schrieb Peter Crosthwaite: > Ping! > > Any objections to this one going in? perhaps even via trivial queue? No strong objection, but you are using an unusual 12-char indentation in some places that you may want to check. Otherwise the cosmetic cleanup looks fine to me. Chee

Re: [Qemu-devel] [PATCH v1 0/3] Serial cleanup

2013-06-10 Thread Peter Crosthwaite
Ping! Any objections to this one going in? perhaps even via trivial queue? Regards, Peter On Mon, Jun 3, 2013 at 3:11 PM, wrote: > From: Peter Crosthwaite > > Some cosmetics, refactored to use util/fifo8 for the FIFO8, then > factored out some common code. > > Tested as working on petalogix-m

[Qemu-devel] [PATCH v1 0/3] Serial cleanup

2013-06-02 Thread peter . crosthwaite
From: Peter Crosthwaite Some cosmetics, refactored to use util/fifo8 for the FIFO8, then factored out some common code. Tested as working on petalogix-ml605 machine model + Linux (has coverage of serial fifo usage). Peter Crosthwaite (3): char/serial: cosmetic fixes. char/serial: Use gener