Re: [Qemu-devel] [PATCH v1 01/10] target/ppc: support for 32-bit carry and overflow

2017-02-21 Thread David Gibson
On Tue, Feb 21, 2017 at 10:15:46AM +0530, Nikunj A Dadhania wrote: > Richard Henderson writes: > > > On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: > >> +#ifndef TARGET_PPC64 > >> static inline target_ulong cpu_read_xer(CPUPPCState *env) > >> { > >> return env->xer |

Re: [Qemu-devel] [PATCH v1 01/10] target/ppc: support for 32-bit carry and overflow

2017-02-20 Thread Nikunj A Dadhania
Richard Henderson writes: > On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: >> +#ifndef TARGET_PPC64 >> static inline target_ulong cpu_read_xer(CPUPPCState *env) >> { >> return env->xer | (env->so << XER_SO) | (env->ov << XER_OV) | (env->ca >> << XER_CA); >> } >>

Re: [Qemu-devel] [PATCH v1 01/10] target/ppc: support for 32-bit carry and overflow

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: +#ifndef TARGET_PPC64 static inline target_ulong cpu_read_xer(CPUPPCState *env) { return env->xer | (env->so << XER_SO) | (env->ov << XER_OV) | (env->ca << XER_CA); } +#else +static inline target_ulong cpu_read_xer(CPUPPCState *env) +{ +

[Qemu-devel] [PATCH v1 01/10] target/ppc: support for 32-bit carry and overflow

2017-02-20 Thread Nikunj A Dadhania
POWER ISA 3.0 adds CA32 and OV32 status in 64-bit mode. Add the flags and corresponding defines. Moreover, CA32 is updated when CA is updated and OV32 is updated when OV is updated. Arithmetic instructions: * Addition and Substractions: addic, addic., subfic, addc, subfc, adde,