Re: [Qemu-devel] [PATCH v1 06/10] target/ppc: use tcg ops for neg instruction

2017-02-21 Thread Nikunj A Dadhania
Richard Henderson writes: > On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: >> static void gen_neg(DisasContext *ctx) >> { >> -gen_op_arith_neg(ctx, 0); >> +tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); >> } >> > > NACK. You're forgetting

Re: [Qemu-devel] [PATCH v1 06/10] target/ppc: use tcg ops for neg instruction

2017-02-20 Thread Richard Henderson
On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: static void gen_neg(DisasContext *ctx) { -gen_op_arith_neg(ctx, 0); +tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); } NACK. You're forgetting "neg.". r~

[Qemu-devel] [PATCH v1 06/10] target/ppc: use tcg ops for neg instruction

2017-02-20 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- target/ppc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 5d8d109..9fa3b5a 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@