Re: [Qemu-devel] [PATCH v1 1/2] tcg: Make probe_write() return a pointer to the host page

2019-08-28 Thread David Hildenbrand
On 28.08.19 16:44, Richard Henderson wrote: > On 8/28/19 4:10 AM, David Hildenbrand wrote: >> + * If the access is permitted, returns the host address similar to >> + * tlb_vaddr_to_host(). Returns NULL in case direct access to the host page >> + * is not allowed or if the size is 0. > > Maybe we

Re: [Qemu-devel] [PATCH v1 1/2] tcg: Make probe_write() return a pointer to the host page

2019-08-28 Thread Richard Henderson
On 8/28/19 4:10 AM, David Hildenbrand wrote: > + * If the access is permitted, returns the host address similar to > + * tlb_vaddr_to_host(). Returns NULL in case direct access to the host page > + * is not allowed or if the size is 0. Maybe we can find some better language -- "not allowed"

[Qemu-devel] [PATCH v1 1/2] tcg: Make probe_write() return a pointer to the host page

2019-08-28 Thread David Hildenbrand
... similar to tlb_vaddr_to_host(); however, allow access to the host page except when TLB_NOTDIRTY or TLB_MMIO is set. Signed-off-by: David Hildenbrand --- accel/tcg/cputlb.c | 22 +- accel/tcg/user-exec.c | 6 -- include/exec/exec-all.h | 4 ++-- 3 files