Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-09-19 Thread Peter Maydell
On 19 September 2017 at 05:43, Edgar E. Iglesias wrote: > On Mon, Sep 18, 2017 at 04:50:23PM +0100, Peter Maydell wrote: >> I'm currently running into a similar issue with M profile, >> where at the moment we stuff the information about what >> kind of fault the MPU

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-09-18 Thread Edgar E. Iglesias
On Mon, Sep 18, 2017 at 04:50:23PM +0100, Peter Maydell wrote: > On 11 July 2017 at 11:38, Edgar E. Iglesias wrote: > > Another way could also be to have get_phys_addr() fill in generic > > fields in the FaultInfo struct and then have a faultinfo_to_fsr > > mapping

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-09-18 Thread Peter Maydell
On 11 July 2017 at 11:38, Edgar E. Iglesias wrote: > Another way could also be to have get_phys_addr() fill in generic > fields in the FaultInfo struct and then have a faultinfo_to_fsr > mapping function to populate FSR/PAR. Do you see any issues with that? Edgar, did

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 11:38, Edgar E. Iglesias wrote: > Another way could also be to have get_phys_addr() fill in generic > fields in the FaultInfo struct and then have a faultinfo_to_fsr > mapping function to populate FSR/PAR. Do you see any issues with that? Yes, that's

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Edgar E. Iglesias
On Tue, Jul 11, 2017 at 11:14:04AM +0100, Peter Maydell wrote: > On 11 July 2017 at 11:03, Edgar E. Iglesias wrote: > > On Mon, Jul 10, 2017 at 04:11:29PM +0100, Peter Maydell wrote: > >> So this kind of worries me, because what it's coded as is "determine > >> whether

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Edgar E. Iglesias
On Tue, Jul 11, 2017 at 11:14:04AM +0100, Peter Maydell wrote: > On 11 July 2017 at 11:03, Edgar E. Iglesias wrote: > > On Mon, Jul 10, 2017 at 04:11:29PM +0100, Peter Maydell wrote: > >> So this kind of worries me, because what it's coded as is "determine > >> whether

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 11:03, Edgar E. Iglesias wrote: > On Mon, Jul 10, 2017 at 04:11:29PM +0100, Peter Maydell wrote: >> So this kind of worries me, because what it's coded as is "determine >> whether architecturally we should be returning a 64-bit or 32-bit >> PAR

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Edgar E. Iglesias
On Mon, Jul 10, 2017 at 04:11:29PM +0100, Peter Maydell wrote: > On 30 June 2017 at 14:45, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Extend PAR format determination to handle more cases. > > > > Signed-off-by: Edgar E.

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-10 Thread Peter Maydell
On 30 June 2017 at 14:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Extend PAR format determination to handle more cases. > > Signed-off-by: Edgar E. Iglesias > --- > target/arm/helper.c | 30

[Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-06-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Extend PAR format determination to handle more cases. Signed-off-by: Edgar E. Iglesias --- target/arm/helper.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git