Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-03 Thread ashish mittal
On Mon, Apr 3, 2017 at 8:11 AM, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 11:25:02AM -0700, ashish mittal wrote: >> On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal wrote: >> > On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-03 Thread Stefan Hajnoczi
On Fri, Mar 31, 2017 at 11:25:02AM -0700, ashish mittal wrote: > On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal wrote: > > On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi > > wrote: > >> On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: >

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-31 Thread ashish mittal
On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal wrote: > On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi wrote: >> On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: >> >> Have you tested live migration? >> >> If live migration is not

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-29 Thread ashish mittal
Hi Jeff, Will incorporate all your review comments with two small dependent changes as follows: @@ -302,14 +286,14 @@ static int vxhs_open(BlockDriverState *bs, QDict *options, int bdrv_flags, Error **errp) { BDRVVXHSState *s = bs->opaque; -void *dev_handlep =

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-28 Thread Jeff Cody
On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: > Source code for the qnio library that this code loads can be downloaded from: > https://github.com/VeritasHyperScale/libqnio.git > > Sample command line using JSON syntax: > ./x86_64-softmmu/qemu-system-x86_64 -name

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-27 Thread ashish mittal
On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi wrote: > On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: > > Have you tested live migration? > > If live migration is not supported then a migration blocker should be > added using migrate_add_blocker(). > We do

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-27 Thread Eric Blake
On 03/27/2017 01:25 PM, ashish mittal wrote: >>> >>> Sample command line using URI syntax: >>> qemu-img convert -f raw -O raw -n >>> /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad >>> vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 >> >> Do we really need URI

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-27 Thread ashish mittal
On Mon, Mar 27, 2017 at 8:56 AM, Eric Blake wrote: > On 03/26/2017 09:50 PM, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git > > When sending a multi-patch series, please

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-27 Thread Stefan Hajnoczi
On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: Have you tested live migration? If live migration is not supported then a migration blocker should be added using migrate_add_blocker(). > v10 changelog: > (1) Implemented accepting TLS creds per block device via the CLI > (see

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-27 Thread Eric Blake
On 03/26/2017 09:50 PM, Ashish Mittal wrote: > Source code for the qnio library that this code loads can be downloaded from: > https://github.com/VeritasHyperScale/libqnio.git When sending a multi-patch series, please include a 0/2 cover letter ('git config format.coverletter auto' can help). >

[Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-26 Thread Ashish Mittal
Source code for the qnio library that this code loads can be downloaded from: https://github.com/VeritasHyperScale/libqnio.git Sample command line using JSON syntax: ./x86_64-softmmu/qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k en-us -vga cirrus -device