Re: [Qemu-devel] [PATCH v10 1/8] msix: Rename and create a wrapper

2017-03-07 Thread Cao jin
On 03/07/2017 03:44 PM, Markus Armbruster wrote: > Uh, two weeks since your posted this already. I apologize for taking so > long to review. > > Cao jin writes: > >> Rename msix_init to msix_validate_and_init, and use it from vfio which >> might get a reasonable

Re: [Qemu-devel] [PATCH v10 1/8] msix: Rename and create a wrapper

2017-03-06 Thread Markus Armbruster
Uh, two weeks since your posted this already. I apologize for taking so long to review. Cao jin writes: > Rename msix_init to msix_validate_and_init, and use it from vfio which > might get a reasonable -EINVAL. New a wrapper msix_init which assert the > programming

[Qemu-devel] [PATCH v10 1/8] msix: Rename and create a wrapper

2017-02-25 Thread Cao jin
Rename msix_init to msix_validate_and_init, and use it from vfio which might get a reasonable -EINVAL. New a wrapper msix_init which assert the programming error for debug purpose and use it from other devices. CC: Alex Williamson CC: Markus Armbruster