Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

On 02/01/2016 05:31 AM, Markus Armbruster wrote: >> |+visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, ); >> | if (err) { >> | goto out; >> | } >> | visit_type_ACPIOSTInfo(v, , "info", ); >> | if (err) { >> |-goto out; >> |+goto out_obj; >> |

Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

Eric Blake writes: > All other successful clients of visit_start_struct() were paired > with an unconditional visit_end_struct(); but the generated > code for events was relying on qmp_output_visitor_cleanup() to > work on an incomplete visit. Alter the code to guarantee that

Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

Eric Blake writes: > On 02/01/2016 05:31 AM, Markus Armbruster wrote: > >>> |+visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, ); >>> | if (err) { >>> | goto out; >>> | } >>> | visit_type_ACPIOSTInfo(v, , "info", ); >>> | if (err) { >>> |-

[Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

All other successful clients of visit_start_struct() were paired with an unconditional visit_end_struct(); but the generated code for events was relying on qmp_output_visitor_cleanup() to work on an incomplete visit. Alter the code to guarantee that the struct is completed, which will make a