Re: [Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support

2013-12-11 Thread Li Guang
Peter Crosthwaite wrote: On Wed, Dec 11, 2013 at 8:31 PM, Peter Maydell wrote: On 11 December 2013 10:24, Peter Crosthwaite wrote: On Wed, Dec 11, 2013 at 7:56 PM, Peter Maydell wrote: On 11 December 2013 05:59, Peter Crosthwaite wrote: On Mon, Dec 9, 2013 at

Re: [Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support

2013-12-11 Thread Peter Crosthwaite
On Wed, Dec 11, 2013 at 8:31 PM, Peter Maydell wrote: > On 11 December 2013 10:24, Peter Crosthwaite > wrote: >> On Wed, Dec 11, 2013 at 7:56 PM, Peter Maydell >> wrote: >>> On 11 December 2013 05:59, Peter Crosthwaite >>> wrote: On Mon, Dec 9, 2013 at 10:10 AM, liguang wrote: > Sign

Re: [Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support

2013-12-11 Thread Peter Maydell
On 11 December 2013 10:24, Peter Crosthwaite wrote: > On Wed, Dec 11, 2013 at 7:56 PM, Peter Maydell > wrote: >> On 11 December 2013 05:59, Peter Crosthwaite >> wrote: >>> On Mon, Dec 9, 2013 at 10:10 AM, liguang wrote: Signed-off-by: liguang >>> >>> Acked-by: Peter Crosthwaite >> >> Wh

Re: [Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support

2013-12-11 Thread Peter Crosthwaite
On Wed, Dec 11, 2013 at 7:56 PM, Peter Maydell wrote: > On 11 December 2013 05:59, Peter Crosthwaite > wrote: >> On Mon, Dec 9, 2013 at 10:10 AM, liguang wrote: >>> Signed-off-by: liguang >> >> Acked-by: Peter Crosthwaite > > Why Acked-by rather than Reviewed-by ? > Not 100% myself on the new

Re: [Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support

2013-12-11 Thread Peter Maydell
On 11 December 2013 05:59, Peter Crosthwaite wrote: > On Mon, Dec 9, 2013 at 10:10 AM, liguang wrote: >> Signed-off-by: liguang > > Acked-by: Peter Crosthwaite Why Acked-by rather than Reviewed-by ? thanks -- PMM

Re: [Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support

2013-12-10 Thread Peter Crosthwaite
On Mon, Dec 9, 2013 at 10:10 AM, liguang wrote: > Signed-off-by: liguang Acked-by: Peter Crosthwaite > --- > hw/arm/Makefile.objs |2 +- > hw/arm/cubieboard.c | 69 > ++ > 2 files changed, 70 insertions(+), 1 deletions(-) > create mode

[Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support

2013-12-08 Thread liguang
Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 69 ++ 2 files changed, 70 insertions(+), 1 deletions(-) create mode 100644 hw/arm/cubieboard.c diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs index 012b