Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Tony Krowiak
On 10/10/2018 05:21 AM, Cornelia Huck wrote: On Tue, 9 Oct 2018 13:52:25 -0400 Tony Krowiak wrote: diff --git a/MAINTAINERS b/MAINTAINERS index 97e8ed808bc0..29041da69237 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1209,6 +1209,7 @@ F: hw/s390x/ap-device.c F: hw/s390x/ap-bridge.c F:

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Tony Krowiak
On 10/10/2018 08:49 AM, Christian Borntraeger wrote: On 10/10/2018 02:37 PM, Pierre Morel wrote: On 09/10/2018 19:52, Tony Krowiak wrote: +static VFIOGroup *vfio_ap_get_group(VFIOAPDevice *vapdev, Error **errp) +{ +GError *gerror; +char *symlink, *group_path; +int groupid; + +

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Tony Krowiak
On 10/09/2018 03:51 PM, David Hildenbrand wrote: +static void vfio_ap_realize(DeviceState *dev, Error **errp) +{ +int ret; +char *mdevid; +Error *local_err = NULL; +VFIOGroup *vfio_group; +APDevice *apdev = AP_DEVICE(dev); +VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev);

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Christian Borntraeger
On 10/10/2018 02:37 PM, Pierre Morel wrote: > On 09/10/2018 19:52, Tony Krowiak wrote: >> +static VFIOGroup *vfio_ap_get_group(VFIOAPDevice *vapdev, Error **errp) >> +{ >> +    GError *gerror; >> +    char *symlink, *group_path; >> +    int groupid; >> + >> +    symlink =

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Pierre Morel
On 09/10/2018 19:52, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Pierre Morel
On 09/10/2018 19:52, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Halil Pasic
On 10/09/2018 07:52 PM, Tony Krowiak wrote: > Introduces a VFIO based AP device. The device is defined via > the QEMU command line by specifying: > > -device vfio-ap,sysfsdev= > > There may be only one vfio-ap device configured for a guest. > > The mediated matrix device is created by

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Cornelia Huck
On Tue, 9 Oct 2018 13:52:25 -0400 Tony Krowiak wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 97e8ed808bc0..29041da69237 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1209,6 +1209,7 @@ F: hw/s390x/ap-device.c > F: hw/s390x/ap-bridge.c > F: include/hw/s390x/ap-device.h > F:

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Cornelia Huck
On Wed, 10 Oct 2018 09:29:10 +0200 Pierre Morel wrote: > On 09/10/2018 21:51, David Hildenbrand wrote: > > > >> +static void vfio_ap_realize(DeviceState *dev, Error **errp) > >> +{ > >> +int ret; > >> +char *mdevid; > >> +Error *local_err = NULL; > >> +VFIOGroup *vfio_group; >

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Pierre Morel
On 09/10/2018 21:51, David Hildenbrand wrote: +static void vfio_ap_realize(DeviceState *dev, Error **errp) +{ +int ret; +char *mdevid; +Error *local_err = NULL; +VFIOGroup *vfio_group; +APDevice *apdev = AP_DEVICE(dev); +VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev); + +

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-09 Thread David Hildenbrand
> +static void vfio_ap_realize(DeviceState *dev, Error **errp) > +{ > +int ret; > +char *mdevid; > +Error *local_err = NULL; > +VFIOGroup *vfio_group; > +APDevice *apdev = AP_DEVICE(dev); > +VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev); > + > +vfio_group =

[Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-09 Thread Tony Krowiak
Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device driver by writing a UUID to a sysfs attribute