Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

On 09/24/2015 04:35 PM, Yang Hongyang wrote: > On 09/24/2015 03:43 PM, Markus Armbruster wrote: >> This has finally reached the front of my review queue. I apologize for >> the lng delay. >> >> Copying Paolo for another pair of eyeballs (he wrote this code). >> > [...] >>> + >>> +opts =

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

On 09/24/2015 05:42 PM, Markus Armbruster wrote: Yang Hongyang writes: On 09/24/2015 03:43 PM, Markus Armbruster wrote: This has finally reached the front of my review queue. I apologize for the lng delay. Copying Paolo for another pair of eyeballs (he wrote

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

On 09/24/2015 05:42 PM, Markus Armbruster wrote: Yang Hongyang writes: On 09/24/2015 03:43 PM, Markus Armbruster wrote: This has finally reached the front of my review queue. I apologize for the lng delay. Copying Paolo for another pair of eyeballs (he wrote

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

Yang Hongyang writes: > On 09/24/2015 05:42 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> On 09/24/2015 03:43 PM, Markus Armbruster wrote: This has finally reached the front of my review queue. I apologize for the lng

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

Yang Hongyang writes: > On 09/24/2015 05:42 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> On 09/24/2015 03:43 PM, Markus Armbruster wrote: This has finally reached the front of my review queue. I apologize for the lng

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

Yang Hongyang writes: > On 09/24/2015 03:43 PM, Markus Armbruster wrote: >> This has finally reached the front of my review queue. I apologize for >> the lng delay. >> >> Copying Paolo for another pair of eyeballs (he wrote this code). >> > [...] >>> + >>> +opts =

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

On 09/24/2015 03:43 PM, Markus Armbruster wrote: This has finally reached the front of my review queue. I apologize for the lng delay. Copying Paolo for another pair of eyeballs (he wrote this code). [...] + +opts = qemu_opts_find(qemu_find_opts_err("object", NULL), id); +

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

This has finally reached the front of my review queue. I apologize for the lng delay. Copying Paolo for another pair of eyeballs (he wrote this code). Yang Hongyang writes: > When delete an object, we need to delete the associated qemu opts, > otherwise, we can not

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

On 09/24/2015 07:35 PM, Markus Armbruster wrote: Yang Hongyang writes: On 09/24/2015 05:42 PM, Markus Armbruster wrote: Yang Hongyang writes: On 09/24/2015 03:43 PM, Markus Armbruster wrote: This has finally reached the front of my review

Re: [Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

On 09/24/2015 07:36 PM, Markus Armbruster wrote: Yang Hongyang writes: On 09/24/2015 05:42 PM, Markus Armbruster wrote: Yang Hongyang writes: On 09/24/2015 03:43 PM, Markus Armbruster wrote: This has finally reached the front of my review

[Qemu-devel] [PATCH v11 01/12] qmp: delete qemu opts when delete an object

When delete an object, we need to delete the associated qemu opts, otherwise, we can not add another object with the same name using object_add. The case happens when we start qemu with: -object xxx,id=aa then we delete this object with: object_del aa then add the object with: object_add xxx,id=aa