Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-13 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Tue, Mar 13, 2018 at 08:04:51PM +0100, Paolo Bonzini wrote: > > On 13/03/2018 19:49, Eduardo Habkost wrote: > > >>> > > >>> Exactly, in other words these two options are part of the guest > > >>> ABI, and QEMU promises to never make the guest ABI

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-13 Thread Eduardo Habkost
On Tue, Mar 13, 2018 at 08:04:51PM +0100, Paolo Bonzini wrote: > On 13/03/2018 19:49, Eduardo Habkost wrote: > >>> > >>> Exactly, in other words these two options are part of the guest > >>> ABI, and QEMU promises to never make the guest ABI depend on the > >>> host hardware unless you're using

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 19:49, Eduardo Habkost wrote: >>> >>> Exactly, in other words these two options are part of the guest >>> ABI, and QEMU promises to never make the guest ABI depend on the >>> host hardware unless you're using "-cpu host". >> >> This is not entirely true; while MAXPHYADDR is constant

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-13 Thread Eduardo Habkost
On Tue, Mar 13, 2018 at 09:42:51AM +0100, Paolo Bonzini wrote: > On 08/03/2018 23:44, Eduardo Habkost wrote: > >> I think doing so will be an issue for the migration. Consider your above > >> use case, a SEV guest is running on EPYC with cbitpos=47 and if we > >> migrate to some $NEXT AMD CPU

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-13 Thread Paolo Bonzini
On 08/03/2018 23:44, Eduardo Habkost wrote: >> I think doing so will be an issue for the migration. Consider your above >> use case, a SEV guest is running on EPYC with cbitpos=47 and if we >> migrate to some $NEXT AMD CPU which uses need to use cbitpos=48 and we >> will fail to resume the guest

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-08 Thread Eduardo Habkost
On Thu, Mar 08, 2018 at 04:22:52PM -0600, Brijesh Singh wrote: > > > On 3/8/18 10:49 AM, Daniel P. Berrangé wrote: > > On Thu, Mar 08, 2018 at 06:48:41AM -0600, Brijesh Singh wrote: > >> Add a new memory encryption object 'sev-guest'. The object will be used > >> to create enrypted VMs on AMD

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-08 Thread Brijesh Singh
On 3/8/18 10:49 AM, Daniel P. Berrangé wrote: > On Thu, Mar 08, 2018 at 06:48:41AM -0600, Brijesh Singh wrote: >> Add a new memory encryption object 'sev-guest'. The object will be used >> to create enrypted VMs on AMD EPYC CPU. The object provides the properties >> to pass guest owner's public

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-08 Thread Daniel P . Berrangé
On Thu, Mar 08, 2018 at 06:48:41AM -0600, Brijesh Singh wrote: > Add a new memory encryption object 'sev-guest'. The object will be used > to create enrypted VMs on AMD EPYC CPU. The object provides the properties > to pass guest owner's public Diffie-hellman key, guest policy and session >

[Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-08 Thread Brijesh Singh
Add a new memory encryption object 'sev-guest'. The object will be used to create enrypted VMs on AMD EPYC CPU. The object provides the properties to pass guest owner's public Diffie-hellman key, guest policy and session information required to create the memory encryption context within the SEV