Re: [Qemu-devel] [PATCH v13 6/8] hw/ptimer: Support running with counter = 0 by introducing new policy feature

2016-06-06 Thread Dmitry Osipenko
On 06.06.2016 13:09, Peter Maydell wrote: On 27 May 2016 at 18:03, Dmitry Osipenko wrote: Bump VMSD version since a new VMState member is added. I'm afraid you can't do that -- the ptimer code is used by a lot of platforms including some which do not permit migration

Re: [Qemu-devel] [PATCH v13 6/8] hw/ptimer: Support running with counter = 0 by introducing new policy feature

2016-06-06 Thread Peter Maydell
On 27 May 2016 at 18:03, Dmitry Osipenko wrote: > Currently ptimer prints error message and clears enable flag for an arming > timer that has delta = load = 0. That actually is a valid case for most > of the timers, like instant IRQ trigger for oneshot timer or continuous in >

Re: [Qemu-devel] [PATCH v13 6/8] hw/ptimer: Support running with counter = 0 by introducing new policy feature

2016-05-28 Thread Dmitry Osipenko
Just a small note: It's more like RFC. I don't think 8 bits would be enough for all possible policies and I don't know whether it is possible to maintain backward compatibility by keeping VMSD .minimum_version_id. "loadvm" refused to accept old ptimer VMState, I haven't looked at it much.

[Qemu-devel] [PATCH v13 6/8] hw/ptimer: Support running with counter = 0 by introducing new policy feature

2016-05-27 Thread Dmitry Osipenko
Currently ptimer prints error message and clears enable flag for an arming timer that has delta = load = 0. That actually is a valid case for most of the timers, like instant IRQ trigger for oneshot timer or continuous in periodic mode. There are different possible policies of how particular timer