Re: [Qemu-devel] [PATCH v14 05/19] qmp-input: Clean up stack handling

2016-04-15 Thread Markus Armbruster
Eric Blake writes: > On 04/13/2016 09:53 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Management of the top of stack was a bit verbose; creating a >>> temporary variable and adding some comments makes the existing >>> code more legible before the next few patches improve things. >>

Re: [Qemu-devel] [PATCH v14 05/19] qmp-input: Clean up stack handling

2016-04-13 Thread Eric Blake
On 04/13/2016 10:36 AM, Eric Blake wrote: >>static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp) >>{ >>assert(qiv->nb_stack > 0); >> >>if (qiv->strict) { >>GHashTable * const top_ht = qiv->stack[qiv->nb_stack - 1].h; >>if (top_ht) { >>

Re: [Qemu-devel] [PATCH v14 05/19] qmp-input: Clean up stack handling

2016-04-13 Thread Eric Blake
On 04/13/2016 09:53 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Management of the top of stack was a bit verbose; creating a >> temporary variable and adding some comments makes the existing >> code more legible before the next few patches improve things. >> No semantic changes other t

Re: [Qemu-devel] [PATCH v14 05/19] qmp-input: Clean up stack handling

2016-04-13 Thread Markus Armbruster
Eric Blake writes: > Management of the top of stack was a bit verbose; creating a > temporary variable and adding some comments makes the existing > code more legible before the next few patches improve things. > No semantic changes other than asserting that we are always > visiting a QObject, an

[Qemu-devel] [PATCH v14 05/19] qmp-input: Clean up stack handling

2016-04-08 Thread Eric Blake
Management of the top of stack was a bit verbose; creating a temporary variable and adding some comments makes the existing code more legible before the next few patches improve things. No semantic changes other than asserting that we are always visiting a QObject, and not a NULL value. Signed-off