Re: [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks

2015-09-23 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > > +if ((now < last || now > (last + get_max_clock_jump())) > > +&& replay_mode == REPLAY_MODE_NONE) { > > notifier_list_notify(>reset_notifiers, ); > > This seems

Re: [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks

2015-09-22 Thread Paolo Bonzini
On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > +if ((now < last || now > (last + get_max_clock_jump())) > +&& replay_mode == REPLAY_MODE_NONE) { > notifier_list_notify(>reset_notifiers, ); This seems wrong. You will have different timers in the record and the

[Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks

2015-09-17 Thread Pavel Dovgalyuk
Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock). When replaying the execution corresponding values are read from log and transfered to the module, which wants to read