Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-20 Thread Gerd Hoffmann
On Mi, 2014-02-19 at 15:40 -0500, Gabriel L. Somlo wrote: On Wed, Feb 19, 2014 at 10:59:34AM +0100, Gerd Hoffmann wrote: Hi, However, when I compare unmodified SMBIOS against what I get when supplying the patched binary table via command line, I get this: As Laszlo already

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-20 Thread Gabriel L. Somlo
On Thu, Feb 20, 2014 at 04:27:27PM +0100, Gerd Hoffmann wrote: On Mi, 2014-02-19 at 15:40 -0500, Gabriel L. Somlo wrote: So I gave up on that relatively quickly, as there's no easy and convenient way to harvest a binary of just one table type from a host that works the way I want it... :(

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-20 Thread Gabriel L. Somlo
On Thu, Feb 20, 2014 at 10:38:04AM -0500, Gabriel L. Somlo wrote: On Thu, Feb 20, 2014 at 04:27:27PM +0100, Gerd Hoffmann wrote: On Mi, 2014-02-19 at 15:40 -0500, Gabriel L. Somlo wrote: So I gave up on that relatively quickly, as there's no easy and convenient way to harvest a binary of

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-20 Thread Gabriel L. Somlo
On Thu, Feb 20, 2014 at 10:42:02AM -0500, Gabriel L. Somlo wrote: On Thu, Feb 20, 2014 at 10:38:04AM -0500, Gabriel L. Somlo wrote: On Thu, Feb 20, 2014 at 04:27:27PM +0100, Gerd Hoffmann wrote: On Mi, 2014-02-19 at 15:40 -0500, Gabriel L. Somlo wrote: So I gave up on that relatively

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-20 Thread Laszlo Ersek
On 02/20/14 16:38, Gabriel L. Somlo wrote: On Thu, Feb 20, 2014 at 04:27:27PM +0100, Gerd Hoffmann wrote: On Mi, 2014-02-19 at 15:40 -0500, Gabriel L. Somlo wrote: So I gave up on that relatively quickly, as there's no easy and convenient way to harvest a binary of just one table type from a

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-19 Thread Gerd Hoffmann
Hi, In my opinion, generating the entire smbios table in QEMU and using the romfile_loader mechanism (see seabios src/fw/romfile_loader.c) would be the preferred solution. I understand that this is more than you signed up for. Yes, this is where we should end up long-term. For the time

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-19 Thread Gerd Hoffmann
Hi, However, when I compare unmodified SMBIOS against what I get when supplying the patched binary table via command line, I get this: As Laszlo already sayed: one table per file. If seabios finds a table provided by qemu it used it, otherwise it (possibly) generates its own. So we

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-19 Thread Gabriel L. Somlo
On Wed, Feb 19, 2014 at 10:59:34AM +0100, Gerd Hoffmann wrote: Hi, However, when I compare unmodified SMBIOS against what I get when supplying the patched binary table via command line, I get this: As Laszlo already sayed: one table per file. So I gave up on that relatively quickly,

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-19 Thread Laszlo Ersek
On 02/19/14 21:40, Gabriel L. Somlo wrote: On Wed, Feb 19, 2014 at 10:59:34AM +0100, Gerd Hoffmann wrote: Hi, However, when I compare unmodified SMBIOS against what I get when supplying the patched binary table via command line, I get this: As Laszlo already sayed: one table per file.

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-18 Thread Gerd Hoffmann
On Mo, 2014-02-17 at 15:33 -0500, Kevin O'Connor wrote: On Mon, Feb 17, 2014 at 11:09:48AM -0500, Gabriel L. Somlo wrote: On Fri, Feb 07, 2014 at 04:37:58PM +0100, Paolo Bonzini wrote: Il 06/02/2014 14:38, Gabriel L. Somlo ha scritto: On Wed, Feb 05, 2014 at 08:02:25PM -0500, Kevin O'Connor

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-18 Thread Gabriel L. Somlo
On Tue, Feb 18, 2014 at 11:21:33AM +0100, Gerd Hoffmann wrote: Unfortunately, if we change the smbios in SeaBIOS, it will show up on all machine types that use the new version of SeaBIOS. We've had issues with this type of change before as various OSes react differently to the change.

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-18 Thread Kevin O'Connor
On Tue, Feb 18, 2014 at 02:17:29PM -0500, Gabriel L. Somlo wrote: Sending a patch against QEMU would have definitely been my first choice, by a wide margin :) But after studying the hw/i386/smbios.c source file in QEMU for a while, I walked away with the impression that all it really tries to

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-18 Thread Laszlo Ersek
On 02/18/14 20:17, Gabriel L. Somlo wrote: On Tue, Feb 18, 2014 at 11:21:33AM +0100, Gerd Hoffmann wrote: Using Fedora 20 live, I collected the SMBIOS table from the guest using dmidecode --dump-bin, with the unpatched SeaBIOS (dmidecode_pc.bin), SeaBIOS with my patch applied

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-18 Thread Laszlo Ersek
On 02/18/14 22:08, Laszlo Ersek wrote: On 02/18/14 20:17, Gabriel L. Somlo wrote: On Tue, Feb 18, 2014 at 11:21:33AM +0100, Gerd Hoffmann wrote: Using Fedora 20 live, I collected the SMBIOS table from the guest using dmidecode --dump-bin, with the unpatched SeaBIOS (dmidecode_pc.bin),

[Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-17 Thread Gabriel L. Somlo
Add v2.3 fields to Type 17 (Memory Device) structure. Add Type 2 (Baseboard) structure. About This Mac on OS X guests will crash and restart the GUI if Type 17 structures are not compliant with at least v2.3 of the SMBIOS/DMI spec. OS X 10.7 and 10.8 will panic during boot if a Type 2

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-17 Thread Kevin O'Connor
On Mon, Feb 17, 2014 at 11:09:48AM -0500, Gabriel L. Somlo wrote: On Fri, Feb 07, 2014 at 04:37:58PM +0100, Paolo Bonzini wrote: Il 06/02/2014 14:38, Gabriel L. Somlo ha scritto: On Wed, Feb 05, 2014 at 08:02:25PM -0500, Kevin O'Connor wrote: Thanks. In general, though, it is preferred to