Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-21 Thread Stefan Hajnoczi
On Tue, Jan 19, 2016 at 01:11:47PM +0100, Gerd Hoffmann wrote: > > If you really think they should be merged, I'd even propose to > > merge the ASM version onto the C version (convert this patch into > > linuxboot.S). This slightly improves readability. > > Fully agree. I'm personally fine with

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-19 Thread Gerd Hoffmann
Hi, > > > +if (fw_cfg_dma_enabled(fw_cfg)) { > > > +option_rom[nb_option_roms].name = "linuxboot_dma.bin"; > > > +option_rom[nb_option_roms].bootindex = 0; > > > +} else { > > > +option_rom[nb_option_roms].name = "linuxboot.bin"; > > > +

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-18 Thread Stefan Hajnoczi
On Mon, Jan 18, 2016 at 10:59:00AM +0100, Marc Marí wrote: > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 459260b..00339fa 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1007,8 +1007,13 @@ static void load_linux(PCMachineState *pcms, > fw_cfg_add_i32(fw_cfg, FW_CFG_SETUP_SIZE,

[Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-18 Thread Marc Marí
This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 + pc-bios/optionrom/Makefile

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-18 Thread Paolo Bonzini
On 18/01/2016 10:59, Marc Marí wrote: > This optionrom is based on linuxboot.S. > > Signed-off-by: Marc Marí Reviewed-by: Paolo Bonzini > --- > .gitignore| 4 + > hw/i386/pc.c | 9 +- >

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-18 Thread Kevin O'Connor
On Mon, Jan 18, 2016 at 05:22:09PM +0100, Marc Marí wrote: > On Mon, 18 Jan 2016 14:42:06 + > Stefan Hajnoczi wrote: > > Was there a technical reason why linuxboot.S cannot be extended > > (e.g. a size limit)? > > I don't think there's a technical reason. It is a lot

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-18 Thread Marc Marí
On Mon, 18 Jan 2016 14:42:06 + Stefan Hajnoczi wrote: > On Mon, Jan 18, 2016 at 10:59:00AM +0100, Marc Marí wrote: > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > index 459260b..00339fa 100644 > > --- a/hw/i386/pc.c > > +++ b/hw/i386/pc.c > > @@ -1007,8 +1007,13 @@