Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm

2010-05-03 Thread Anthony Liguori
On 04/20/2010 02:28 AM, Gerd Hoffmann wrote: Hi, Not much traffic on this thread ;-) Indeed ;) I can see the usefulness of an init_late() to generalize post device setup issues. I assume then that you didn't have any other issues with my patch, other than general code structure

Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm

2010-04-20 Thread Gerd Hoffmann
Hi, Not much traffic on this thread ;-) Indeed ;) I can see the usefulness of an init_late() to generalize post device setup issues. I assume then that you didn't have any other issues with my patch, other than general code structure concerns? Yes, that is the major one. I think it

Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm

2010-04-19 Thread Bruce Rogers
On 4/14/2010 at 01:24 AM, Gerd Hoffmann kra...@redhat.com wrote: Hi, When specifying ide devices using -device, the cmos information which the bios depends on is not written. This patch generalizes the cmos hd data setting for the existing code path and adds the ability to call that

Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm

2010-04-14 Thread Gerd Hoffmann
Hi, When specifying ide devices using -device, the cmos information which the bios depends on is not written. This patch generalizes the cmos hd data setting for the existing code path and adds the ability to call that code on a per machine, per ide drive basis. Hmm. With -device and thus

[Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm

2010-04-13 Thread Bruce Rogers
When specifying ide devices using -device, the cmos information which the bios depends on is not written. This patch generalizes the cmos hd data setting for the existing code path and adds the ability to call that code on a per machine, per ide drive basis. This is important for older