Re: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

2017-11-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface Type: series Message-id: alpine.DEB.2.10.1711061412330.30448@sstabellini-ThinkPad-X260 === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

2017-11-07 Thread Peter Maydell
On 7 November 2017 at 17:57, Stefano Stabellini wrote: > On Tue, 7 Nov 2017, Peter Maydell wrote: >> I thought about this on the cycle into work this morning, and I >> think that rather than require every board that uses gicv3 >> to set a property on the CPU, we should

Re: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

2017-11-07 Thread Stefano Stabellini
On Tue, 7 Nov 2017, Peter Maydell wrote: > On 6 November 2017 at 22:16, Stefano Stabellini > wrote: > > When QEMU emulates a GICv3, it needs to advertise the presence of the > > system register interface, which is done via id_aa64pfr0. > > > > To do that, and at the same

Re: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

2017-11-07 Thread Peter Maydell
On 6 November 2017 at 22:16, Stefano Stabellini wrote: > When QEMU emulates a GICv3, it needs to advertise the presence of the > system register interface, which is done via id_aa64pfr0. > > To do that, and at the same time to avoid advertising the presence of > the system

[Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

2017-11-06 Thread Stefano Stabellini
When QEMU emulates a GICv3, it needs to advertise the presence of the system register interface, which is done via id_aa64pfr0. To do that, and at the same time to avoid advertising the presence of the system register interface when it is actually not available, set a boolean property in