Re: [Qemu-devel] [PATCH v2] block: fix QEMU crash with scsi-hd and drive_del

On Thu, 24 May 2018 17:52:56 +0100 Stefan Hajnoczi wrote: > On Thu, May 24, 2018 at 11:09:47AM +0200, Greg Kurz wrote: > > diff --git a/block.c b/block.c > > index 676e57f5623a..fc9379439883 100644 > > --- a/block.c > > +++ b/block.c > > @@ -2127,12 +2127,16 @@ BdrvChild

Re: [Qemu-devel] [PATCH v2] block: fix QEMU crash with scsi-hd and drive_del

On Thu, May 24, 2018 at 11:09:47AM +0200, Greg Kurz wrote: > diff --git a/block.c b/block.c > index 676e57f5623a..fc9379439883 100644 > --- a/block.c > +++ b/block.c > @@ -2127,12 +2127,16 @@ BdrvChild *bdrv_attach_child(BlockDriverState > *parent_bs, > > static void

Re: [Qemu-devel] [PATCH v2] block: fix QEMU crash with scsi-hd and drive_del

On Thu, May 24, 2018 at 11:09:47AM +0200, Greg Kurz wrote: > Removing a drive with drive_del while it is being used to run an I/O > intensive workload can cause QEMU to crash. > > An AIO flush can yield at some point: > > blk_aio_flush_entry() > blk_co_flush(blk) >

[Qemu-devel] [PATCH v2] block: fix QEMU crash with scsi-hd and drive_del

Removing a drive with drive_del while it is being used to run an I/O intensive workload can cause QEMU to crash. An AIO flush can yield at some point: blk_aio_flush_entry() blk_co_flush(blk) bdrv_co_flush(blk->root->bs) ... qemu_coroutine_yield() and let the HMP command to run, free