Re: [Qemu-devel] [PATCH v2] block: support dropping active in bdrv_drop_intermediate

2013-10-24 Thread Jeff Cody
On Tue, Oct 15, 2013 at 03:25:00PM +0800, Fam Zheng wrote: There is only one failure point: bdrv_change_backing_file in this function, so we can drop the qlist and try to change the backing file before deleting anything. This way bdrv_drop_intermediate is simplified while keeping the

Re: [Qemu-devel] [PATCH v2] block: support dropping active in bdrv_drop_intermediate

2013-10-18 Thread Eric Blake
On 10/15/2013 01:25 AM, Fam Zheng wrote: There is only one failure point: bdrv_change_backing_file in this function, so we can drop the qlist and try to change the backing file before deleting anything. This way bdrv_drop_intermediate is simplified while keeping the operation transactional.

[Qemu-devel] [PATCH v2] block: support dropping active in bdrv_drop_intermediate

2013-10-15 Thread Fam Zheng
There is only one failure point: bdrv_change_backing_file in this function, so we can drop the qlist and try to change the backing file before deleting anything. This way bdrv_drop_intermediate is simplified while keeping the operation transactional. A bonus is dropping an active BDS is supported