Re: [Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag

2013-11-04 Thread Fam Zheng
Cc'ing qemu-stable. Fam On 10/15/2013 05:45 PM, Fam Zheng wrote: Since 0ebd24e0, cdrom doesn't have read-only on by default, which will error out when using an read only image. Fix it by setting the default value when parsing opts. Reported-by: Edivaldo de Araujo Pereira Signed-off-by: Fam Zh

Re: [Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag

2013-10-17 Thread Stefan Hajnoczi
On Tue, Oct 15, 2013 at 05:45:50PM +0800, Fam Zheng wrote: > Since 0ebd24e0, cdrom doesn't have read-only on by default, which will > error out when using an read only image. Fix it by setting the default > value when parsing opts. > > Reported-by: Edivaldo de Araujo Pereira > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag

2013-10-15 Thread Kevin Wolf
Am 15.10.2013 um 11:45 hat Fam Zheng geschrieben: > Since 0ebd24e0, cdrom doesn't have read-only on by default, which will > error out when using an read only image. Fix it by setting the default > value when parsing opts. > > Reported-by: Edivaldo de Araujo Pereira > Signed-off-by: Fam Zheng >

[Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag

2013-10-15 Thread Fam Zheng
Since 0ebd24e0, cdrom doesn't have read-only on by default, which will error out when using an read only image. Fix it by setting the default value when parsing opts. Reported-by: Edivaldo de Araujo Pereira Signed-off-by: Fam Zheng --- v2: fix backward compatibility by force read-only with cdro