Re: [Qemu-devel] [PATCH v2] blockjob: kick jobs on set-speed

2017-12-14 Thread Jeff Cody
On Wed, Dec 13, 2017 at 03:46:11PM -0500, John Snow wrote: > If users set an unreasonably low speed (like one byte per second), the > calculated delay may exceed many hours. While we like to punish users > for asking for stupid things, we do also like to allow users to correct > their wicked ways.

Re: [Qemu-devel] [PATCH v2] blockjob: kick jobs on set-speed

2017-12-14 Thread Stefan Hajnoczi
On Wed, Dec 13, 2017 at 03:46:11PM -0500, John Snow wrote: > If users set an unreasonably low speed (like one byte per second), the > calculated delay may exceed many hours. While we like to punish users > for asking for stupid things, we do also like to allow users to correct > their wicked ways.

Re: [Qemu-devel] [PATCH v2] blockjob: kick jobs on set-speed

2017-12-13 Thread Paolo Bonzini
On 13/12/2017 21:46, John Snow wrote: > > When a user provides a new speed, kick the job to allow it to recalculate > its delay. > > Signed-off-by: John Snow > --- > > RFC: Why is block_job_mutex shared between all jobs, > instead of being per-job? Because that patch

[Qemu-devel] [PATCH v2] blockjob: kick jobs on set-speed

2017-12-13 Thread John Snow
If users set an unreasonably low speed (like one byte per second), the calculated delay may exceed many hours. While we like to punish users for asking for stupid things, we do also like to allow users to correct their wicked ways. When a user provides a new speed, kick the job to allow it to