Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Pankaj Gupta
> > Hi > > On Thu, Feb 7, 2019 at 11:13 AM Pankaj Gupta wrote: > > > > > > > > > Thanks for your reply. Please find my reply inline. > > > > > > > > > > > > > Hotplugging existing char chardev with qmp, > > > > > > > > dereferences(removes) > > > > > > > > existing chardev. This patch avoids

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Marc-André Lureau
Hi On Thu, Feb 7, 2019 at 11:13 AM Pankaj Gupta wrote: > > > > > > Thanks for your reply. Please find my reply inline. > > > > > > > > > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > > > > > > existing chardev. This patch avoids adding a chardev if a chardev > > > > >

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Pankaj Gupta
> > > Thanks for your reply. Please find my reply inline. > > > > > > > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > > > > > existing chardev. This patch avoids adding a chardev if a chardev > > > > > > with same id exists. > > > > > > > > > > As you pointed out, if

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Daniel P . Berrangé
On Thu, Feb 07, 2019 at 10:11:29AM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Feb 7, 2019 at 8:21 AM Pankaj Gupta wrote: > > > > > > Hi Daniel, Marc-Andre, > > > > Thanks for your reply. Please find my reply inline. > > > > > > > Hotplugging existing char chardev with qmp,

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Marc-André Lureau
Hi On Thu, Feb 7, 2019 at 8:21 AM Pankaj Gupta wrote: > > > Hi Daniel, Marc-Andre, > > Thanks for your reply. Please find my reply inline. > > > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > > > existing chardev. This patch avoids adding a chardev if a chardev > > > >

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-06 Thread Pankaj Gupta
Hi Daniel, Marc-Andre, Thanks for your reply. Please find my reply inline. > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > > existing chardev. This patch avoids adding a chardev if a chardev > > > with same id exists. > > > > As you pointed out, if you attempt to

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-06 Thread Daniel P . Berrangé
On Wed, Feb 06, 2019 at 05:08:25PM +0100, Marc-André Lureau wrote: > Hi > > On Tue, Jan 29, 2019 at 7:36 AM Pankaj Gupta wrote: > > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > existing chardev. This patch avoids adding a chardev if a chardev > > with same id exists.

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-06 Thread Marc-André Lureau
Hi On Tue, Jan 29, 2019 at 7:36 AM Pankaj Gupta wrote: > > Hotplugging existing char chardev with qmp, dereferences(removes) > existing chardev. This patch avoids adding a chardev if a chardev > with same id exists. As you pointed out, if you attempt to add a chardev with an existing ID, you

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-01-29 Thread Stefano Garzarella
On Tue, Jan 29, 2019 at 11:58:01AM +0530, Pankaj Gupta wrote: > Hotplugging existing char chardev with qmp, dereferences(removes) > existing chardev. This patch avoids adding a chardev if a chardev > with same id exists. > > RH BZ 1660831: > > # (host) ls -lt /tmp/helloworld* > srwxr-xr-x.

[Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-01-28 Thread Pankaj Gupta
Hotplugging existing char chardev with qmp, dereferences(removes) existing chardev. This patch avoids adding a chardev if a chardev with same id exists. RH BZ 1660831: # (host) ls -lt /tmp/helloworld* srwxr-xr-x. /tmp/helloworld1 srwxr-xr-x. /tmp/helloworld2 Before this patch: hotplug