Re: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

2018-03-06 Thread Paolo Bonzini
On 06/03/2018 15:31, Stefan Hajnoczi wrote: > On Fri, Mar 02, 2018 at 01:43:19PM +0300, Julia Suvorova wrote: >> g_path_get_* do the same as g_strdup(basename/dirname(...)) but >> without modifying the argument. >> >> Signed-off-by: Julia Suvorova >> --- >> scripts/checkpatch.pl | 5 + >> 1 f

Re: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

2018-03-06 Thread Stefan Hajnoczi
On Fri, Mar 02, 2018 at 01:43:19PM +0300, Julia Suvorova wrote: > g_path_get_* do the same as g_strdup(basename/dirname(...)) but > without modifying the argument. > > Signed-off-by: Julia Suvorova > --- > scripts/checkpatch.pl | 5 + > 1 file changed, 5 insertions(+) Thanks, applied to my

Re: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

2018-03-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1519987399-19160-1-git-send-email-jus...@mail.ru Subject: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname === TEST SCRIPT BEGIN === #!/bin/bash BASE

[Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

2018-03-02 Thread Julia Suvorova via Qemu-devel
g_path_get_* do the same as g_strdup(basename/dirname(...)) but without modifying the argument. Signed-off-by: Julia Suvorova --- scripts/checkpatch.pl | 5 + 1 file changed, 5 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 1b4b812..a88af61 100755 --- a/scrip