Re: [Qemu-devel] [PATCH v2] ide: fix enum comparison for gcc 4.7

2017-09-22 Thread Peter Maydell
On 21 September 2017 at 13:25, Stefan Hajnoczi wrote: > On Wed, Sep 20, 2017 at 09:38:21PM -0400, John Snow wrote: >> Apparently GCC gets bent over comparing enum values against zero. >> Replace the conditional with something less readable. >> >> Tested-by: Mark Cave-Ayland

Re: [Qemu-devel] [PATCH v2] ide: fix enum comparison for gcc 4.7

2017-09-21 Thread Stefan Hajnoczi
On Wed, Sep 20, 2017 at 09:38:21PM -0400, John Snow wrote: > Apparently GCC gets bent over comparing enum values against zero. > Replace the conditional with something less readable. > > Tested-by: Mark Cave-Ayland > Signed-off-by: John Snow > >

[Qemu-devel] [PATCH v2] ide: fix enum comparison for gcc 4.7

2017-09-20 Thread John Snow
Apparently GCC gets bent over comparing enum values against zero. Replace the conditional with something less readable. Tested-by: Mark Cave-Ayland Signed-off-by: John Snow --- v2: Second verse, same as the first. Signed-off-by: John Snow