Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-21 Thread Paolo Bonzini
On 07/09/2016 23:27, Eric Blake wrote: > When qemu uses iscsi devices in sg mode, iscsilun->block_size > is left at 0. Prior to commits cf081fca and similar, when > block limits were tracked in sectors, this did not matter: > various block limits were just left at 0. But when we started >

Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-09 Thread Holger Schranz
Hello Eric, Kevin, Paolo, Thank you very much for the very fast help. All works fine now!!! Best regards and have nice weekend Holger Am 08.09.2016 um 19:34 schrieb Holger Schranz: Hi Eric, Am 08.09.2016 um 17:25 schrieb Eric Blake: On 09/08/2016 09:27 AM, Holger Schranz wrote: Hi Eric,

Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Holger Schranz
Hi Eric, Am 08.09.2016 um 17:25 schrieb Eric Blake: On 09/08/2016 09:27 AM, Holger Schranz wrote: Hi Eric, Thanks a lot, it seems the patch works. The VM starting. Should I take that as a Tested-by: line? The test was: 1) login as root 2) cd to workdir 3) start virt-viewer: "virt-viewer

Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Paolo Bonzini
On 08/09/2016 17:25, Eric Blake wrote: > On 09/08/2016 09:27 AM, Holger Schranz wrote: >> Hi Eric, >> >> Thanks a lot, it seems the patch works. The VM starting. > > Should I take that as a Tested-by: line? > >> Unfortunately we run into the next issue. By the accessing the >> megasas

Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Holger Schranz
Hi Eric, Thanks a lot, it seems the patch works. The VM starting. Unfortunately we run into the next issue. By the accessing the megasas controller we got a SIGSEGV. See the trave below. Best regards Holger === Thread 4

Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Ralf Mueller
On 09/08/2016 05:25 PM, Eric Blake wrote: On 09/08/2016 09:27 AM, Holger Schranz wrote: Hi Eric, Thanks a lot, it seems the patch works. The VM starting. Should I take that as a Tested-by: line? Unfortunately we run into the next issue. By the accessing the megasas controller we got a

Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Eric Blake
On 09/08/2016 09:27 AM, Holger Schranz wrote: > Hi Eric, > > Thanks a lot, it seems the patch works. The VM starting. Should I take that as a Tested-by: line? > Unfortunately we run into the next issue. By the accessing the > megasas controller we got a SIGSEGV. Seems unrelated, let's figure

[Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-07 Thread Eric Blake
When qemu uses iscsi devices in sg mode, iscsilun->block_size is left at 0. Prior to commits cf081fca and similar, when block limits were tracked in sectors, this did not matter: various block limits were just left at 0. But when we started scaling by block size, this caused SIGFPE. Then, in a