Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-17 Thread Philippe Mathieu-Daudé
On Fri, May 17, 2019 at 11:30 AM Jakub Jermar wrote: > > Hi Aleksandar and Philippe, > > On 5/16/19 8:04 PM, Aleksandar Markovic wrote: [...] > > I tested Jakub's scenario too, it works as expected, but I am not > > concerned about it as much as about regression tests. Knowing that you > > have

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-17 Thread Jakub Jermar
Hi Aleksandar and Philippe, On 5/16/19 8:04 PM, Aleksandar Markovic wrote: > > On May 16, 2019 6:31 PM, "Philippe Mathieu-Daudé" > wrote: >> >> Hi Jakub, >> >> On 5/16/19 3:10 PM, Jakub Jermar wrote: >> > Hi, >> > >> > On 5/3/19 12:02 PM, Jakub Jermar wrote: >> >> Hi,

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-17 Thread Jakub Jermar
Hi Philippe, On 5/16/19 6:31 PM, Philippe Mathieu-Daudé wrote: > Hi Jakub, > > On 5/16/19 3:10 PM, Jakub Jermar wrote: >> Hi, >> >> On 5/3/19 12:02 PM, Jakub Jermar wrote: >>> Hi, >>> >>> On 4/23/19 4:58 PM, Jakub Jermar wrote: Hi Philippe! On 4/23/19 3:48 PM, Philippe

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Aleksandar Markovic
On May 16, 2019 10:05 PM, "Philippe Mathieu-Daudé" wrote: > > On 5/16/19 8:04 PM, Aleksandar Markovic wrote: > > On May 16, 2019 6:31 PM, "Philippe Mathieu-Daudé" wrote: > >> > >> Hi Jakub, > >> > >> On 5/16/19 3:10 PM, Jakub Jermar wrote: > >>> Hi, > >>> > >>> On 5/3/19 12:02 PM, Jakub Jermar

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 8:04 PM, Aleksandar Markovic wrote: > On May 16, 2019 6:31 PM, "Philippe Mathieu-Daudé" wrote: >> >> Hi Jakub, >> >> On 5/16/19 3:10 PM, Jakub Jermar wrote: >>> Hi, >>> >>> On 5/3/19 12:02 PM, Jakub Jermar wrote: Hi, On 4/23/19 4:58 PM, Jakub Jermar wrote: > Hi

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Aleksandar Markovic
On May 16, 2019 6:31 PM, "Philippe Mathieu-Daudé" wrote: > > Hi Jakub, > > On 5/16/19 3:10 PM, Jakub Jermar wrote: > > Hi, > > > > On 5/3/19 12:02 PM, Jakub Jermar wrote: > >> Hi, > >> > >> On 4/23/19 4:58 PM, Jakub Jermar wrote: > >>> Hi Philippe! > >>> > >>> On 4/23/19 3:48 PM, Philippe

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Philippe Mathieu-Daudé
Hi Jakub, On 5/16/19 3:10 PM, Jakub Jermar wrote: > Hi, > > On 5/3/19 12:02 PM, Jakub Jermar wrote: >> Hi, >> >> On 4/23/19 4:58 PM, Jakub Jermar wrote: >>> Hi Philippe! >>> >>> On 4/23/19 3:48 PM, Philippe Mathieu-Daudé wrote: Hi Jakub, On 4/23/19 1:00 PM, Jakub Jermář wrote:

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Aleksandar Markovic
On May 16, 2019 3:11 PM, "Jakub Jermar" wrote: > > Hi, > > On 5/3/19 12:02 PM, Jakub Jermar wrote: > > Hi, > > > > On 4/23/19 4:58 PM, Jakub Jermar wrote: > >> Hi Philippe! > >> > >> On 4/23/19 3:48 PM, Philippe Mathieu-Daudé wrote: > >>> Hi Jakub, > >>> > >>> On 4/23/19 1:00 PM, Jakub Jermář

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Jakub Jermar
Hi, On 5/3/19 12:02 PM, Jakub Jermar wrote: > Hi, > > On 4/23/19 4:58 PM, Jakub Jermar wrote: >> Hi Philippe! >> >> On 4/23/19 3:48 PM, Philippe Mathieu-Daudé wrote: >>> Hi Jakub, >>> >>> On 4/23/19 1:00 PM, Jakub Jermář wrote: This commit addresses QEMU Bug #1825311:

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-03 Thread Aleksandar Markovic
> (ping) > > Is there anything else I can do to help to get this merged? > > https://patchew.org/QEMU/20190423110034.1260142-1-jakub.jer...@kernkonzept.com/ Hello, Jakub. I will be reviewing your patch next week, please be patient. In any case, thanks for your involving in solving this issue!

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-03 Thread Jakub Jermar
Hi, On 4/23/19 4:58 PM, Jakub Jermar wrote: > Hi Philippe! > > On 4/23/19 3:48 PM, Philippe Mathieu-Daudé wrote: >> Hi Jakub, >> >> On 4/23/19 1:00 PM, Jakub Jermář wrote: >>> This commit addresses QEMU Bug #1825311: >>> >>> mips_cpu_handle_mmu_fault renders all accessed pages executable >>>

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-04-23 Thread Jakub Jermar
Hi Philippe! On 4/23/19 3:48 PM, Philippe Mathieu-Daudé wrote: > Hi Jakub, > > On 4/23/19 1:00 PM, Jakub Jermář wrote: >> This commit addresses QEMU Bug #1825311: >> >> mips_cpu_handle_mmu_fault renders all accessed pages executable >> >> It allows finer-grained control over whether the

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-04-23 Thread Philippe Mathieu-Daudé
Hi Jakub, On 4/23/19 1:00 PM, Jakub Jermář wrote: > This commit addresses QEMU Bug #1825311: > > mips_cpu_handle_mmu_fault renders all accessed pages executable > > It allows finer-grained control over whether the accessed page should be > executable by moving the decision to the underlying

[Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-04-23 Thread Jakub Jermář
This commit addresses QEMU Bug #1825311: mips_cpu_handle_mmu_fault renders all accessed pages executable It allows finer-grained control over whether the accessed page should be executable by moving the decision to the underlying map_address function, which has more information for this. As a