Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: It's more friendly to print which char is invalid to user, especially when user tries to input a float value and expect the monitor to round it to int. Since we don't round float number when we look for a integer, telling which char is invalid is less

Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Eric Blake
On 08/19/2013 08:58 PM, Fam Zheng wrote: It's more friendly to print which char is invalid to user, especially when user tries to input a float value and expect the monitor to round it to int. Since we don't round float number when we look for a integer, telling which char is invalid is less

Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Luiz Capitulino
On Tue, 20 Aug 2013 10:58:21 +0800 Fam Zheng f...@redhat.com wrote: It's more friendly to print which char is invalid to user, especially when user tries to input a float value and expect the monitor to round it to int. Since we don't round float number when we look for a integer, telling

[Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-19 Thread Fam Zheng
It's more friendly to print which char is invalid to user, especially when user tries to input a float value and expect the monitor to round it to int. Since we don't round float number when we look for a integer, telling which char is invalid is less confusing. Signed-off-by: Fam Zheng