Re: [Qemu-devel] [PATCH v2] raw-posix: Detect legacy floppy via ioctl

2010-01-13 Thread Anthony Liguori
On 01/12/2010 09:29 AM, Cole Robinson wrote: Current legacy floppy detection is hardcoded based on source file name. Make this smarter by attempting a floppy specific ioctl. v2: Give ioctl check higher priority than filename check, s/IDE/legacy/ Signed-off-by: Cole

Re: [Qemu-devel] [PATCH v2] raw-posix: Detect legacy floppy via ioctl

2010-01-13 Thread Cole Robinson
On 01/13/2010 06:07 PM, Anthony Liguori wrote: On 01/12/2010 09:29 AM, Cole Robinson wrote: Current legacy floppy detection is hardcoded based on source file name. Make this smarter by attempting a floppy specific ioctl. v2: Give ioctl check higher priority than filename check,

[Qemu-devel] [PATCH v2] raw-posix: Detect legacy floppy via ioctl

2010-01-12 Thread Cole Robinson
Current legacy floppy detection is hardcoded based on source file name. Make this smarter by attempting a floppy specific ioctl. v2: Give ioctl check higher priority than filename check, s/IDE/legacy/ Signed-off-by: Cole Robinson crobi...@redhat.com --- block/raw-posix.c | 20

Re: [Qemu-devel] [PATCH v2] raw-posix: Detect legacy floppy via ioctl

2010-01-12 Thread Christoph Hellwig
Looks good, same comment applies as to the cdrom one.