Re: [Qemu-devel] [PATCH v2] s390x/kvm: fix and cleanup storing CPU status

2017-09-26 Thread Cornelia Huck
On Fri, 22 Sep 2017 16:03:38 +0200 David Hildenbrand wrote: > env->psa is a 64bit value, while we copy 4 bytes into the save area, > resulting always in 0 getting stored. > > Let's try to reduce such errors by using a proper structure. While at > it, use correct cpu->be

Re: [Qemu-devel] [PATCH v2] s390x/kvm: fix and cleanup storing CPU status

2017-09-25 Thread Thomas Huth
On 22.09.2017 16:03, David Hildenbrand wrote: > env->psa is a 64bit value, while we copy 4 bytes into the save area, > resulting always in 0 getting stored. > > Let's try to reduce such errors by using a proper structure. While at > it, use correct cpu->be conversion (and get_psw_mask()), as we

Re: [Qemu-devel] [PATCH v2] s390x/kvm: fix and cleanup storing CPU status

2017-09-22 Thread Richard Henderson
On 09/22/2017 09:03 AM, David Hildenbrand wrote: > env->psa is a 64bit value, while we copy 4 bytes into the save area, > resulting always in 0 getting stored. > > Let's try to reduce such errors by using a proper structure. While at > it, use correct cpu->be conversion (and get_psw_mask()), as

[Qemu-devel] [PATCH v2] s390x/kvm: fix and cleanup storing CPU status

2017-09-22 Thread David Hildenbrand
env->psa is a 64bit value, while we copy 4 bytes into the save area, resulting always in 0 getting stored. Let's try to reduce such errors by using a proper structure. While at it, use correct cpu->be conversion (and get_psw_mask()), as we will be reusing this code for TCG soon. Signed-off-by: