Re: [Qemu-devel] [PATCH v2] scsi-block: Add qdev error properties

2017-08-18 Thread Fam Zheng
On Fri, 08/18 08:41, Paolo Bonzini wrote: > On 18/08/2017 05:38, Fam Zheng wrote: > > On Thu, 08/17 16:23, Paolo Bonzini wrote: > >>> +if (scsi_sense_matches(r, SENSE_CODE(NO_MEDIUM))) { > >>> +error = ENOMEDIUM; > >>> +} else if (scsi_sense_matches(r,

Re: [Qemu-devel] [PATCH v2] scsi-block: Add qdev error properties

2017-08-18 Thread Paolo Bonzini
On 18/08/2017 05:38, Fam Zheng wrote: > On Thu, 08/17 16:23, Paolo Bonzini wrote: >>> +if (scsi_sense_matches(r, SENSE_CODE(NO_MEDIUM))) { >>> +error = ENOMEDIUM; >>> +} else if (scsi_sense_matches(r, SENSE_CODE(TARGET_FAILURE))) { >>> +error = ENOMEM; >>> +

Re: [Qemu-devel] [PATCH v2] scsi-block: Add qdev error properties

2017-08-17 Thread Fam Zheng
On Thu, 08/17 16:23, Paolo Bonzini wrote: > > +if (scsi_sense_matches(r, SENSE_CODE(NO_MEDIUM))) { > > +error = ENOMEDIUM; > > +} else if (scsi_sense_matches(r, SENSE_CODE(TARGET_FAILURE))) { > > +error = ENOMEM; > > +} else if (scsi_sense_matches(r,

Re: [Qemu-devel] [PATCH v2] scsi-block: Add qdev error properties

2017-08-17 Thread Paolo Bonzini
On 17/08/2017 16:11, Fam Zheng wrote: > This makes the werror/rerror options available on the scsi-block device, > to allow user specify error handling policy in the same way as scsi-hd > etc. > > Signed-off-by: Fam Zheng > > --- > > Take care of status, error, sense and QMP

[Qemu-devel] [PATCH v2] scsi-block: Add qdev error properties

2017-08-17 Thread Fam Zheng
This makes the werror/rerror options available on the scsi-block device, to allow user specify error handling policy in the same way as scsi-hd etc. Signed-off-by: Fam Zheng --- Take care of status, error, sense and QMP as well. [Paolo] --- hw/scsi/scsi-disk.c | 81