Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-07-01 Thread Vladimir Sementsov-Ogievskiy
On 01.07.2016 11:12, Kevin Wolf wrote: Am 30.06.2016 um 19:23 hat Denis V. Lunev geschrieben: On 06/30/2016 07:40 PM, John Snow wrote: On 06/30/2016 05:12 AM, Denis V. Lunev wrote: On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: After loading bitmap from image and setting IN_USE

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-07-01 Thread Kevin Wolf
Am 30.06.2016 um 19:23 hat Denis V. Lunev geschrieben: > On 06/30/2016 07:40 PM, John Snow wrote: > > > >On 06/30/2016 05:12 AM, Denis V. Lunev wrote: > >>On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: > >>>After loading bitmap from image and setting IN_USE flag in it's header, >

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-30 Thread Denis V. Lunev
On 06/30/2016 07:40 PM, John Snow wrote: On 06/30/2016 05:12 AM, Denis V. Lunev wrote: On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: After loading bitmap from image and setting IN_USE flag in it's header, corresponding data (bitmap table and data clusters) becomes inconsistent

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-30 Thread John Snow
On 06/30/2016 05:12 AM, Denis V. Lunev wrote: > On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: >> After loading bitmap from image and setting IN_USE flag in it's header, >> corresponding data (bitmap table and data clusters) becomes inconsistent >> and is no longer needed. It is

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-30 Thread Denis V. Lunev
On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: After loading bitmap from image and setting IN_USE flag in it's header, corresponding data (bitmap table and data clusters) becomes inconsistent and is no longer needed. It is better to free bitmap table and corresponding clusters from

[Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-30 Thread Vladimir Sementsov-Ogievskiy
After loading bitmap from image and setting IN_USE flag in it's header, corresponding data (bitmap table and data clusters) becomes inconsistent and is no longer needed. It is better to free bitmap table and corresponding clusters from the image immediately after loading the bitmap than free them