Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-14 Thread Peter Maydell
On Fri, 14 Dec 2018 at 09:16, Li Qiang wrote: > First of all I want to know does the following error means? > doesn't it mean "the x86 qtest is ok and aarch64 is not ok"? > > > GTESTER check-qtest-x86_64 > GTESTER check-qtest-aarch64 > vhost-user-test: /tmp/qemu-test/src/util/oslib-posix.c:245

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-14 Thread Li Qiang
Li Qiang 于2018年12月14日周五 上午9:46写道: > Hi all, > > Here is the error. > > GTESTER check-qtest-x86_64 > Unable to get file status flag on fd 21860: Bad file descriptor(errno=9) > GTESTER check-qtest-aarch64 > Broken pipe > GTester: last random seed: R02S3f0d6981dd97231d06e0b2966baf94b9 > Unable t

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-13 Thread Li Qiang
Hi all, Here is the error. GTESTER check-qtest-x86_64 Unable to get file status flag on fd 21860: Bad file descriptor(errno=9) GTESTER check-qtest-aarch64 Broken pipe GTester: last random seed: R02S3f0d6981dd97231d06e0b2966baf94b9 Unable to get file status flag on fd 21965: Bad file descripto

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1544701071-2922-1-git-send-email-liq...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT B

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-13 Thread Markus Armbruster
Li Qiang writes: > Also add diagnostics info in 'qemu_set_cloexec' so that we can know > what happen when error occurs. > > Signed-off-by: Li Qiang > --- > Change since v1: add diagnostics info > > util/oslib-posix.c | 37 - > 1 file changed, 32 insertions(

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-13 Thread Li Qiang
Peter Maydell 于2018年12月13日周四 下午7:45写道: > On Thu, 13 Dec 2018 at 11:37, Li Qiang wrote: > > > > Also add diagnostics info in 'qemu_set_cloexec' so that we can know > > what happen when error occurs. > > > > Signed-off-by: Li Qiang > > --- > > Change since v1: add diagnostics info > > We need to

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-13 Thread Daniel P . Berrangé
On Thu, Dec 13, 2018 at 11:45:22AM +, Peter Maydell wrote: > On Thu, 13 Dec 2018 at 11:37, Li Qiang wrote: > > > > Also add diagnostics info in 'qemu_set_cloexec' so that we can know > > what happen when error occurs. > > > > Signed-off-by: Li Qiang > > --- > > Change since v1: add diagnostic

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-13 Thread Peter Maydell
On Thu, 13 Dec 2018 at 11:37, Li Qiang wrote: > > Also add diagnostics info in 'qemu_set_cloexec' so that we can know > what happen when error occurs. > > Signed-off-by: Li Qiang > --- > Change since v1: add diagnostics info We need to fix the assert in the test suite first... thanks -- PMM

[Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-13 Thread Li Qiang
Also add diagnostics info in 'qemu_set_cloexec' so that we can know what happen when error occurs. Signed-off-by: Li Qiang --- Change since v1: add diagnostics info util/oslib-posix.c | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/uti