Re: [Qemu-devel] [PATCH v2] virtio: Fix setting up host notifiers for vhost

2016-06-30 Thread Cornelia Huck
On Thu, 30 Jun 2016 16:12:31 +0200 Marc-André Lureau wrote: > Hi > > On Thu, Jun 30, 2016 at 1:52 PM, Cornelia Huck > wrote: > > When setting up host notifiers, virtio_bus_set_host_notifier() > > simply switches the handler. This will only

Re: [Qemu-devel] [PATCH v2] virtio: Fix setting up host notifiers for vhost

2016-06-30 Thread Marc-André Lureau
Hi On Thu, Jun 30, 2016 at 1:52 PM, Cornelia Huck wrote: > When setting up host notifiers, virtio_bus_set_host_notifier() > simply switches the handler. This will only work, however, if > the ioeventfd has already been setup; this is true for dataplane, > but not for

Re: [Qemu-devel] [PATCH v2] virtio: Fix setting up host notifiers for vhost

2016-06-30 Thread Peter Lieven
Am 30.06.2016 um 13:52 schrieb Cornelia Huck: When setting up host notifiers, virtio_bus_set_host_notifier() simply switches the handler. This will only work, however, if the ioeventfd has already been setup; this is true for dataplane, but not for vhost, and will completely break things if the

[Qemu-devel] [PATCH v2] virtio: Fix setting up host notifiers for vhost

2016-06-30 Thread Cornelia Huck
When setting up host notifiers, virtio_bus_set_host_notifier() simply switches the handler. This will only work, however, if the ioeventfd has already been setup; this is true for dataplane, but not for vhost, and will completely break things if the ioeventfd is disabled for the device. Fix this