Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-02-07 Thread Mark Cave-Ayland
On 05/02/2019 21:29, Mark Cave-Ayland wrote: > Now that this and the other pre-requisite patches have been merged into > master, I've > rebased the outstanding PPC parts of your "tcg, target/ppc vector > improvements" on > master including the above fix and pushed the result to >

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-02-06 Thread BALATON Zoltan
On Wed, 6 Feb 2019, Mark Cave-Ayland wrote: Howard has also pointed out that he's still spotted some corruption in his tests, so I will do a bit more investigation and report back. I wonder if instead of "visually testing" shouldn't it be verified by some more exact tests? Could any of these

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-02-05 Thread Mark Cave-Ayland
On 06/02/2019 03:37, Richard Henderson wrote: > On 2/5/19 9:29 PM, Mark Cave-Ayland wrote: >> The only minor question I had with the patchset in its current form is >> whether to use >> the new VsrD() macro for vscr_sat, or whether we don't really care enough? > > Given the comment > > /*

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-02-05 Thread Richard Henderson
On 2/5/19 9:29 PM, Mark Cave-Ayland wrote: > The only minor question I had with the patchset in its current form is > whether to use > the new VsrD() macro for vscr_sat, or whether we don't really care enough? Given the comment /* Which bit we set is completely arbitrary, but clear the rest.

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-02-05 Thread Mark Cave-Ayland
On 23/01/2019 05:09, Richard Henderson wrote: > On 1/7/19 5:11 AM, Mark Cave-Ayland wrote: >> #7 0x55852e53 in expand_4_vec (vece=2, dofs=197872, >> aofs=198288, bofs=197776, cofs=197792, oprsz=16, tysz=16, >> type=TCG_TYPE_V128, write_aofs=true, fni=0x5599182a >> ) at >>

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-01-22 Thread Richard Henderson
On 1/7/19 5:11 AM, Mark Cave-Ayland wrote: > #7 0x55852e53 in expand_4_vec (vece=2, dofs=197872, > aofs=198288, bofs=197776, cofs=197792, oprsz=16, tysz=16, > type=TCG_TYPE_V128, write_aofs=true, fni=0x5599182a > ) at > /home/hsp/src/qemu-altivec-55/tcg/tcg-op-gvec.c:903 > t0

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-01-07 Thread Mark Cave-Ayland
On 04/01/2019 22:31, Richard Henderson wrote: > I've split this out from the target/ppc patch set in which > it was developed. > > > r~ > > > Richard Henderson (10): > tcg: Add logical simplifications during gvec expand > tcg: Add gvec expanders for nand, nor, eqv > tcg: Add write_aofs

[Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-01-04 Thread Richard Henderson
I've split this out from the target/ppc patch set in which it was developed. r~ Richard Henderson (10): tcg: Add logical simplifications during gvec expand tcg: Add gvec expanders for nand, nor, eqv tcg: Add write_aofs to GVecGen4 tcg: Add opcodes for vector saturated arithmetic tcg: