Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-29 Thread Bryan Venteicher
On Mon, May 27, 2013 at 6:15 AM, Rusty Russell ru...@rustcorp.com.auwrote: Anthony Liguori anth...@codemonkey.ws writes: Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I should have looked at linux/types.h (actually

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-29 Thread Anthony Liguori
Rusty Russell ru...@rustcorp.com.au writes: Anthony Liguori anth...@codemonkey.ws writes: The headers say they are BSD licensed... but they include a GPLv2+ header. Doesn't make a lot of sense, does it? It makes perfect sense: you're overthinking it. It just means that copying the BSD

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-29 Thread Michael S. Tsirkin
On Wed, May 29, 2013 at 08:05:29AM -0500, Anthony Liguori wrote: Rusty Russell ru...@rustcorp.com.au writes: Anthony Liguori anth...@codemonkey.ws writes: The headers say they are BSD licensed... but they include a GPLv2+ header. Doesn't make a lot of sense, does it? It makes perfect

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-29 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Wed, May 29, 2013 at 08:05:29AM -0500, Anthony Liguori wrote: Rusty Russell ru...@rustcorp.com.au writes: Anthony Liguori anth...@codemonkey.ws writes: The headers say they are BSD licensed... but they include a GPLv2+ header. Doesn't make

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-28 Thread Michael S. Tsirkin
On Mon, May 27, 2013 at 11:14:47AM -0500, Anthony Liguori wrote: Well specifically if_ether.h says GPLv2+ so it's OK for QEMU. Do you mean for some other non GPL app? Ignore QEMU for the moment. The headers say they are BSD licensed... but they include a GPLv2+ header. Above is a bit

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-28 Thread Rusty Russell
Anthony Liguori anth...@codemonkey.ws writes: The headers say they are BSD licensed... but they include a GPLv2+ header. Doesn't make a lot of sense, does it? It makes perfect sense: you're overthinking it. It just means that copying the BSD headers outside Linux is encouraged. And it's

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-28 Thread Rusty Russell
Anthony Liguori anth...@codemonkey.ws writes: Rusty Russell ru...@rustcorp.com.au writes: Anthony Liguori anth...@codemonkey.ws writes: Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I should have looked at linux/types.h (actually

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Peter Maydell
On 26 May 2013 19:10, Michael S. Tsirkin m...@redhat.com wrote: Ouch. Forgot to git-add them. Thanks. I'll send a fixed version - could you please try this patch on top? With this extra patch MacOSX compiles. thanks -- PMM

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Michael S. Tsirkin
On Sun, May 26, 2013 at 07:55:25PM -0500, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: On Sun, May 26, 2013 at 03:49:53PM -0500, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Sun, May 26, 2013 at 07:55:25PM -0500, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: On Sun, May 26, 2013 at 03:49:53PM -0500, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02,

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Rusty Russell
Anthony Liguori anth...@codemonkey.ws writes: Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I should have looked at linux/types.h (actually asm-generic/). Not really, __uX appear in the headers that were posted. Which is a

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Anthony Liguori
Rusty Russell ru...@rustcorp.com.au writes: Anthony Liguori anth...@codemonkey.ws writes: Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I should have looked at linux/types.h (actually asm-generic/). Not really, __uX appear in the

[Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Michael S. Tsirkin
virtio linux headers are actually pretty portable: all we need is implement linux/types.h in a portable way, and we can import them and use on any platform. These patches do exactly that, as a pre-requisite to adding support for new virtio layout. Note: if someone adds non-portable code in files

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Peter Maydell
On 26 May 2013 16:22, Michael S. Tsirkin m...@redhat.com wrote: virtio linux headers are actually pretty portable: all we need is implement linux/types.h in a portable way, and we can import them and use on any platform. These patches do exactly that, as a pre-requisite to adding support for

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Michael S. Tsirkin
On Sun, May 26, 2013 at 04:43:57PM +0100, Peter Maydell wrote: On 26 May 2013 16:22, Michael S. Tsirkin m...@redhat.com wrote: virtio linux headers are actually pretty portable: all we need is implement linux/types.h in a portable way, and we can import them and use on any platform.

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Peter Maydell
On 26 May 2013 18:51, Michael S. Tsirkin m...@redhat.com wrote: On Sun, May 26, 2013 at 04:43:57PM +0100, Peter Maydell wrote: This series breaks compilation on MacOSX: CCnet/eth.o In file included from net/eth.c:18: In file included from /Users/pm215/src/qemu/include/net/eth.h:29:

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Michael S. Tsirkin
On Sun, May 26, 2013 at 07:00:58PM +0100, Peter Maydell wrote: On 26 May 2013 18:51, Michael S. Tsirkin m...@redhat.com wrote: On Sun, May 26, 2013 at 04:43:57PM +0100, Peter Maydell wrote: This series breaks compilation on MacOSX: CCnet/eth.o In file included from net/eth.c:18:

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Paolo Bonzini
Il 26/05/2013 20:10, Michael S. Tsirkin ha scritto: On Sun, May 26, 2013 at 07:00:58PM +0100, Peter Maydell wrote: On 26 May 2013 18:51, Michael S. Tsirkin m...@redhat.com wrote: On Sun, May 26, 2013 at 04:43:57PM +0100, Peter Maydell wrote: This series breaks compilation on MacOSX: CC

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Michael S. Tsirkin
On Sun, May 26, 2013 at 08:26:14PM +0200, Paolo Bonzini wrote: Il 26/05/2013 20:10, Michael S. Tsirkin ha scritto: On Sun, May 26, 2013 at 07:00:58PM +0100, Peter Maydell wrote: On 26 May 2013 18:51, Michael S. Tsirkin m...@redhat.com wrote: On Sun, May 26, 2013 at 04:43:57PM +0100, Peter

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Paolo Bonzini
Il 26/05/2013 20:37, Michael S. Tsirkin ha scritto: I don't like defining __-prefixed types. Can we preprocess linux-headers to avoid usage of __u8/16/32/64, and to s,linux/types.h,stdint.h, ? Paolo Let's not be purists, and do the practical thing. When I suggested this you didn't

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Michael S. Tsirkin
On Sun, May 26, 2013 at 08:53:33PM +0200, Paolo Bonzini wrote: Il 26/05/2013 20:37, Michael S. Tsirkin ha scritto: I don't like defining __-prefixed types. Can we preprocess linux-headers to avoid usage of __u8/16/32/64, and to s,linux/types.h,stdint.h, ? Paolo Let's not be

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Paolo Bonzini
Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I should have looked at linux/types.h (actually asm-generic/). Not really, __uX appear in the headers that were posted. What I'm saying is - a chance of a conflict is very remote, if it happens it's a build failure so easy to

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I should have looked at linux/types.h (actually asm-generic/). Not really, __uX appear in the headers that were posted. Which is a problem because this is a reserved namespace in C99.

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Michael S. Tsirkin
On Sun, May 26, 2013 at 03:49:53PM -0500, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I should have looked at linux/types.h (actually asm-generic/). Not really, __uX appear in the headers that were

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Sun, May 26, 2013 at 03:49:53PM -0500, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: My fault. I should have looked at linux/types.h (actually asm-generic/). Not