Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Richard Henderson
On 01/09/2018 06:43 AM, Peter Maydell wrote: > On 9 January 2018 at 14:20, Laurent Vivier wrote: >> Le 09/01/2018 à 15:14, Peter Maydell a écrit : >>> Is gcc's codegen still bad enough that we have to default to not >>> using the type-checking versions? If so, maybe we could at

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Alex Bennée
Laurent Vivier writes: > Le 09/01/2018 à 15:14, Peter Maydell a écrit: >> On 9 January 2018 at 14:12, Aurelien Jarno wrote: >>> On 2018-01-09 13:27, Laurent Vivier wrote: Le 09/01/2018 à 13:22, Alex Bennée a écrit : > It's not actively built

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 14:20, Laurent Vivier wrote: > Le 09/01/2018 à 15:14, Peter Maydell a écrit : >> Is gcc's codegen still bad enough that we have to default to not >> using the type-checking versions? If so, maybe we could at least >> enable the type-checking on an

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Laurent Vivier
Le 09/01/2018 à 15:14, Peter Maydell a écrit : > On 9 January 2018 at 14:12, Aurelien Jarno wrote: >> On 2018-01-09 13:27, Laurent Vivier wrote: >>> Le 09/01/2018 à 13:22, Alex Bennée a écrit : It's not actively built and when enabled things fail to compile. I'm

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 14:12, Aurelien Jarno wrote: > On 2018-01-09 13:27, Laurent Vivier wrote: >> Le 09/01/2018 à 13:22, Alex Bennée a écrit : >> > It's not actively built and when enabled things fail to compile. I'm >> > not sure the type-checking is really helping here.

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Aurelien Jarno
On 2018-01-09 13:27, Laurent Vivier wrote: > Le 09/01/2018 à 13:22, Alex Bennée a écrit : > > It's not actively built and when enabled things fail to compile. I'm > > not sure the type-checking is really helping here. Seeing as we "own" > > our softfloat now lets remove the cruft. > > I think it

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Laurent Vivier
Le 09/01/2018 à 13:22, Alex Bennée a écrit : > It's not actively built and when enabled things fail to compile. I'm > not sure the type-checking is really helping here. Seeing as we "own" > our softfloat now lets remove the cruft. I think it would be better to fix the build break than to remove

[Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Alex Bennée
It's not actively built and when enabled things fail to compile. I'm not sure the type-checking is really helping here. Seeing as we "own" our softfloat now lets remove the cruft. Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 27 --- 1