Re: [Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context

2016-10-13 Thread Paolo Bonzini
On 13/10/2016 02:49, John Snow wrote: > As context to everyone else as to why I'm going down the rabbit hole of > trying to remove external references to AioContext at all, see > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00795.html > > On 10/07/2016 03:49 AM, Paolo Bonzini wrote:

Re: [Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context

2016-10-12 Thread John Snow
As context to everyone else as to why I'm going down the rabbit hole of trying to remove external references to AioContext at all, see https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00795.html On 10/07/2016 03:49 AM, Paolo Bonzini wrote: On 06/10/2016 22:22, John Snow wrote:

Re: [Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context

2016-10-07 Thread Paolo Bonzini
On 06/10/2016 22:22, John Snow wrote: > Calls .complete(), for which the only implementation is > mirror_complete. Uh, this actually seems messy. Looks like there's > nothing to prevent us from calling this after we've already told it to > complete once. Yeah, it should have an if

Re: [Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context

2016-10-06 Thread John Snow
On 10/05/2016 10:02 AM, Kevin Wolf wrote: Am 01.10.2016 um 00:00 hat John Snow geschrieben: There are a few places where we're fishing it out for ourselves. Let's not do that and instead use the helper. Signed-off-by: John Snow That change makes a difference when the

Re: [Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context

2016-10-05 Thread Kevin Wolf
Am 01.10.2016 um 00:00 hat John Snow geschrieben: > There are a few places where we're fishing it out for ourselves. > Let's not do that and instead use the helper. > > Signed-off-by: John Snow That change makes a difference when the block job is running its completion part

[Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context

2016-09-30 Thread John Snow
There are a few places where we're fishing it out for ourselves. Let's not do that and instead use the helper. Signed-off-by: John Snow --- block/io.c | 4 ++-- blockdev.c | 4 ++-- blockjob.c | 2 +- include/block/blockjob.h | 9