Re: [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov

2015-09-29 Thread Michael S. Tsirkin
On Fri, Sep 25, 2015 at 03:14:59PM +0200, Gerd Hoffmann wrote: > On Do, 2015-09-24 at 13:16 +0300, Michael S. Tsirkin wrote: > > On Thu, Sep 24, 2015 at 11:04:55AM +0200, Gerd Hoffmann wrote: > > > Signed-off-by: Gerd Hoffmann > > > > It's easy to see this is what the patch

Re: [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov

2015-09-28 Thread Max Reitz
On 24.09.2015 11:04, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/display/virtio-gpu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Max Reitz You could even make the parameter a struct iovec **, which is then

Re: [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov

2015-09-25 Thread Gerd Hoffmann
On Do, 2015-09-24 at 13:16 +0300, Michael S. Tsirkin wrote: > On Thu, Sep 24, 2015 at 11:04:55AM +0200, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > It's easy to see this is what the patch does. But why? Some > explanation in the commit log about why it's done,

Re: [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov

2015-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2015 at 11:04:55AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann It's easy to see this is what the patch does. But why? Some explanation in the commit log about why it's done, as opposed to what is done, would be better. > --- >

[Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov

2015-09-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index a67d927..73bd9b6 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -563,7