Re: [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state

2009-12-02 Thread Gleb Natapov
On Tue, Dec 01, 2009 at 10:51:31AM -0200, Glauber Costa wrote: This fix a bug with -smp in kvm. Since we have updated apic_base, we also have to tell kernel about it. So instead of just updating mp_state, update every regs. It is mandatory that this happens synchronously, without waiting for

Re: [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state

2009-12-02 Thread Glauber Costa
+{ +    if (kvm_enabled()) { Is this ever called or intended to be called when kvm is disabled? +        kvm_cpu_flush_state(env); +    } I don't think so. But this is here for consistency with its synchronize brother. -- Glauber Costa. Free as in Freedom http://glommer.net The less

[Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state

2009-12-01 Thread Glauber Costa
This fix a bug with -smp in kvm. Since we have updated apic_base, we also have to tell kernel about it. So instead of just updating mp_state, update every regs. It is mandatory that this happens synchronously, without waiting for the next vcpu run. Otherwise, if we are migrating, or initializing