Re: [Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations

2018-03-04 Thread Peter Xu
On Fri, Mar 02, 2018 at 10:51:01AM +, Daniel P. Berrangé wrote: > On Fri, Mar 02, 2018 at 11:58:52AM +0800, Peter Xu wrote: > > On Thu, Mar 01, 2018 at 10:47:17AM +, Daniel P. Berrangé wrote: > > > On Thu, Mar 01, 2018 at 04:44:28PM +0800, Peter Xu wrote: > > > > Three functions are

Re: [Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations

2018-03-02 Thread Daniel P . Berrangé
On Fri, Mar 02, 2018 at 11:58:52AM +0800, Peter Xu wrote: > On Thu, Mar 01, 2018 at 10:47:17AM +, Daniel P. Berrangé wrote: > > On Thu, Mar 01, 2018 at 04:44:28PM +0800, Peter Xu wrote: > > > Three functions are abstracted from the old code: > > > > > > - qio_net_listener_source_add(): create

Re: [Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations

2018-03-01 Thread Peter Xu
On Fri, Mar 02, 2018 at 11:58:52AM +0800, Peter Xu wrote: > On Thu, Mar 01, 2018 at 10:47:17AM +, Daniel P. Berrangé wrote: > > On Thu, Mar 01, 2018 at 04:44:28PM +0800, Peter Xu wrote: > > > Three functions are abstracted from the old code: > > > > > > - qio_net_listener_source_add(): create

Re: [Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations

2018-03-01 Thread Peter Xu
On Thu, Mar 01, 2018 at 10:47:17AM +, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 04:44:28PM +0800, Peter Xu wrote: > > Three functions are abstracted from the old code: > > > > - qio_net_listener_source_add(): create one source for listener > > - qio_net_listener_sources_clear():

Re: [Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations

2018-03-01 Thread Daniel P . Berrangé
On Thu, Mar 01, 2018 at 04:44:28PM +0800, Peter Xu wrote: > Three functions are abstracted from the old code: > > - qio_net_listener_source_add(): create one source for listener > - qio_net_listener_sources_clear(): unset existing net lister sources > - qio_net_listener_sources_update(): setup

[Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations

2018-03-01 Thread Peter Xu
Three functions are abstracted from the old code: - qio_net_listener_source_add(): create one source for listener - qio_net_listener_sources_clear(): unset existing net lister sources - qio_net_listener_sources_update(): setup all sources for listener Use them where possible. Signed-off-by: