Re: [Qemu-devel] [PATCH v2 06/14] crypto: Change the qcrypto_random_bytes buffer type to void*

2019-03-14 Thread Philippe Mathieu-Daudé
On 3/14/19 5:55 AM, Richard Henderson wrote: > Using uint8_t* merely requires useless casts for use with > other types to be filled with randomness. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > include/crypto/random.h | 2 +- >

Re: [Qemu-devel] [PATCH v2 06/14] crypto: Change the qcrypto_random_bytes buffer type to void*

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:18PM -0700, Richard Henderson wrote: > Using uint8_t* merely requires useless casts for use with > other types to be filled with randomness. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson > --- > include/crypto/random.h | 2 +- >

[Qemu-devel] [PATCH v2 06/14] crypto: Change the qcrypto_random_bytes buffer type to void*

2019-03-13 Thread Richard Henderson
Using uint8_t* merely requires useless casts for use with other types to be filled with randomness. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- include/crypto/random.h | 2 +- crypto/random-gcrypt.c | 2 +- crypto/random-gnutls.c | 2 +- crypto/random-platform.c | 4 ++--