Re: [Qemu-devel] [PATCH v2 09/10] pci/shpc: perform unplug via the hotplug handler

2018-11-20 Thread David Hildenbrand
On 20.11.18 15:13, Igor Mammedov wrote: > On Tue, 20 Nov 2018 11:11:46 +0100 > David Hildenbrand wrote: > diff --git a/hw/pci-bridge/pcie_pci_bridge.c b/hw/pci-bridge/pcie_pci_bridge.c index c634353b06..7c667bc97c 100644 --- a/hw/pci-bridge/pcie_pci_bridge.c +++ b/hw/pci

Re: [Qemu-devel] [PATCH v2 09/10] pci/shpc: perform unplug via the hotplug handler

2018-11-20 Thread Igor Mammedov
On Tue, 20 Nov 2018 11:11:46 +0100 David Hildenbrand wrote: > >> diff --git a/hw/pci-bridge/pcie_pci_bridge.c > >> b/hw/pci-bridge/pcie_pci_bridge.c > >> index c634353b06..7c667bc97c 100644 > >> --- a/hw/pci-bridge/pcie_pci_bridge.c > >> +++ b/hw/pci-bridge/pcie_pci_bridge.c > >> @@ -150,6 +150,

Re: [Qemu-devel] [PATCH v2 09/10] pci/shpc: perform unplug via the hotplug handler

2018-11-20 Thread David Hildenbrand
>> diff --git a/hw/pci-bridge/pcie_pci_bridge.c >> b/hw/pci-bridge/pcie_pci_bridge.c >> index c634353b06..7c667bc97c 100644 >> --- a/hw/pci-bridge/pcie_pci_bridge.c >> +++ b/hw/pci-bridge/pcie_pci_bridge.c >> @@ -150,6 +150,19 @@ static void pcie_pci_bridge_plug_cb(HotplugHandler >> *hotplug_dev,

Re: [Qemu-devel] [PATCH v2 09/10] pci/shpc: perform unplug via the hotplug handler

2018-11-19 Thread Igor Mammedov
On Mon, 5 Nov 2018 11:20:43 +0100 David Hildenbrand wrote: > Introduce and use the "unplug" callback. > > This is a preparation for multi-stage hotplug handlers, whereby the bus > hotplug handler is overwritten by the machine hotplug handler. This handler > will then pass control to the bus hot

Re: [Qemu-devel] [PATCH v2 09/10] pci/shpc: perform unplug via the hotplug handler

2018-11-06 Thread David Gibson
On Mon, Nov 05, 2018 at 11:20:43AM +0100, David Hildenbrand wrote: > Introduce and use the "unplug" callback. > > This is a preparation for multi-stage hotplug handlers, whereby the bus > hotplug handler is overwritten by the machine hotplug handler. This handler > will then pass control to the bu

[Qemu-devel] [PATCH v2 09/10] pci/shpc: perform unplug via the hotplug handler

2018-11-05 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure