Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-30 Thread Markus Armbruster
Max Reitz mre...@redhat.com writes: On 28.05.2014 16:25, Markus Armbruster wrote: Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand.

Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-30 Thread Max Reitz
On 30.05.2014 08:56, Markus Armbruster wrote: Max Reitz mre...@redhat.com writes: On 28.05.2014 16:25, Markus Armbruster wrote: Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned

[Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-28 Thread Markus Armbruster
Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-img.c | 32

Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-28 Thread Max Reitz
On 28.05.2014 16:25, Markus Armbruster wrote: Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-28 Thread Max Reitz
On 28.05.2014 16:25, Markus Armbruster wrote: Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image

2014-05-28 Thread Max Reitz
On 28.05.2014 23:26, Max Reitz wrote: On 28.05.2014 16:25, Markus Armbruster wrote: Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand.