Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2014/1/3 Paolo Bonzini > Il 02/01/2014 15:45, Andreas Färber ha scritto: > >>> >> v2: Consolidate VNC macro's #ifdef'ery to one central point > (tests/libqtest.c). > >> > > >> > What happens if qtest instead uses "-display none"? > > It does use that, since the commit I pointed to in v1. :) > >

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

Il 02/01/2014 15:45, Andreas Färber ha scritto: >>> >> v2: Consolidate VNC macro's #ifdef'ery to one central point >>> >> (tests/libqtest.c). >> > >> > What happens if qtest instead uses "-display none"? > It does use that, since the commit I pointed to in v1. :) And why do you need at all "-vn

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

On Fri, Jan 3, 2014 at 1:01 PM, Kewei Yu wrote: > > 2014/1/2 Andreas Färber >> >> Am 01.01.2014 05:40, schrieb Peter Crosthwaite: >> > On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu wrote: >> >> 2013/12/31 Peter Crosthwaite >> >>> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: >> When we di

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2014/1/2 Andreas Färber > Am 01.01.2014 05:40, schrieb Peter Crosthwaite: > > On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu wrote: > >> 2013/12/31 Peter Crosthwaite > >>> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: > When we disabling vnc from "./configure", the qemu can't use the vnc >

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

Am 01.01.2014 05:40, schrieb Peter Crosthwaite: > On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu wrote: >> 2013/12/31 Peter Crosthwaite >>> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: When we disabling vnc from "./configure", the qemu can't use the vnc option. [...] So qtest can'

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

Am 02.01.2014 09:15, schrieb Paolo Bonzini: > Il 31/12/2013 05:42, Kewei Yu ha scritto: >> When we disabling vnc from "./configure", the qemu can't use the vnc option. >> So qtest can't use the "vnc -none ", otherwise "make check" will hang. >> >> Signed-off-by: Kewei Yu >> --- >> v2: Consolidate

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

The fail is caused by "-vnc none", we can't use it when disable vnc from "./configure". Faithfully yours Kewei Yu 2014/1/2 Paolo Bonzini > Il 31/12/2013 05:42, Kewei Yu ha scritto: > > When we disabling vnc from "./configure", the qemu can't use the vnc > option. > > So qtest can't use the "v

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

Il 31/12/2013 05:42, Kewei Yu ha scritto: > When we disabling vnc from "./configure", the qemu can't use the vnc option. > So qtest can't use the "vnc -none ", otherwise "make check" will hang. > > Signed-off-by: Kewei Yu > --- > v2: Consolidate VNC macro's #ifdef'ery to one central point > (te

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu wrote: > 2013/12/31 Peter Crosthwaite >> >> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: >> > When we disabling vnc from "./configure", the qemu can't use the vnc >> > option. >> >> "disable", -"the", "QEMU", > > Do you mean "s/disabling/disable; s/

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

On Wed, Jan 1, 2014 at 12:29 PM, Kewei Yu wrote: > > 2014/1/1 Peter Maydell >> >> On 31 December 2013 13:29, Kewei Yu wrote: >> > 2013/12/31 Peter Crosthwaite >> >> >> >> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: >> >> >"%s", qemu_binary, s->socket_pa

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2014/1/1 Peter Maydell > On 31 December 2013 13:29, Kewei Yu wrote: > > 2013/12/31 Peter Crosthwaite > >> > >> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: > >> >"%s", qemu_binary, s->socket_path, > >> >s->qmp_socket_p

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

On 31 December 2013 13:29, Kewei Yu wrote: > 2013/12/31 Peter Crosthwaite >> >> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: >> >"%s", qemu_binary, s->socket_path, >> >s->qmp_socket_path, pid_file, >> > +

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

Peter: Happy new year, Today is new year's day, so I will present the v3 patch according to your suggestions tomorrow , thanks for your review. Faithfully yours Kewei Yu 2013/12/31 Kewei Yu > 2013/12/31 Peter Crosthwaite > >> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: >> > Whe

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2013/12/31 Peter Crosthwaite > On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: > > When we disabling vnc from "./configure", the qemu can't use the vnc > option. > > "disable", -"the", "QEMU", > Do you mean "s/disabling/disable; s/the\ qemu/QEMU"? > > > So qtest can't use the "vnc -none ", oth

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: > When we disabling vnc from "./configure", the qemu can't use the vnc option. "disable", -"the", "QEMU", > So qtest can't use the "vnc -none ", otherwise "make check" will hang. > Curious, why exactly does make check hang? Shouldn't it just fail

[Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

When we disabling vnc from "./configure", the qemu can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" will hang. Signed-off-by: Kewei Yu --- v2: Consolidate VNC macro's #ifdef'ery to one central point (tests/libqtest.c). tests/fdc-test.c |5 + tests/i