Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-12-09 Thread David Gibson
On Fri, Dec 04, 2015 at 05:04:16PM -0800, Nishanth Aravamudan wrote: > On 01.12.2015 [14:41:25 +1100], David Gibson wrote: > > On Thu, Nov 12, 2015 at 08:46:27AM -0800, Nishanth Aravamudan wrote: > > > On 12.11.2015 [15:47:15 +1100], David Gibson wrote: > > > > On Wed, Nov 11, 2015 at 02:10:48PM

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-12-04 Thread Nishanth Aravamudan
On 01.12.2015 [14:41:25 +1100], David Gibson wrote: > On Thu, Nov 12, 2015 at 08:46:27AM -0800, Nishanth Aravamudan wrote: > > On 12.11.2015 [15:47:15 +1100], David Gibson wrote: > > > On Wed, Nov 11, 2015 at 02:10:48PM -0800, Nishanth Aravamudan wrote: > > > > On 11.11.2015 [12:41:26 +1100],

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-30 Thread David Gibson
On Thu, Nov 12, 2015 at 08:46:27AM -0800, Nishanth Aravamudan wrote: > On 12.11.2015 [15:47:15 +1100], David Gibson wrote: > > On Wed, Nov 11, 2015 at 02:10:48PM -0800, Nishanth Aravamudan wrote: > > > On 11.11.2015 [12:41:26 +1100], David Gibson wrote: > > > > On Tue, Nov 10, 2015 at 04:56:38PM

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-13 Thread Sukadev Bhattiprolu
Thomas Huth [th...@redhat.com] wrote: | On 10/11/15 05:22, Sukadev Bhattiprolu wrote: | [...] | > | > +static int file_read_buf(char *file_name, char *buf, int len) | > | > +{ | > | > +int rc; | > | > +FILE *fp; | > | > + | > | > +fp = fopen(file_name, "r"); | > | > +if (!fp) { | >

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-13 Thread Sukadev Bhattiprolu
David Gibson [da...@gibson.dropbear.id.au] wrote: | On Mon, Nov 09, 2015 at 08:22:32PM -0800, Sukadev Bhattiprolu wrote: | > David Gibson [da...@gibson.dropbear.id.au] wrote: | > | On Wed, Nov 04, 2015 at 03:06:05PM -0800, Sukadev Bhattiprolu wrote: | > | > Implement

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-12 Thread Nishanth Aravamudan
On 12.11.2015 [15:47:15 +1100], David Gibson wrote: > On Wed, Nov 11, 2015 at 02:10:48PM -0800, Nishanth Aravamudan wrote: > > On 11.11.2015 [12:41:26 +1100], David Gibson wrote: > > > On Tue, Nov 10, 2015 at 04:56:38PM -0800, Nishanth Aravamudan wrote: > > > > On 11.11.2015 [11:17:58 +1100],

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-11 Thread David Gibson
On Wed, Nov 11, 2015 at 02:10:48PM -0800, Nishanth Aravamudan wrote: > On 11.11.2015 [12:41:26 +1100], David Gibson wrote: > > On Tue, Nov 10, 2015 at 04:56:38PM -0800, Nishanth Aravamudan wrote: > > > On 11.11.2015 [11:17:58 +1100], David Gibson wrote: > > > > On Mon, Nov 09, 2015 at 08:22:32PM

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-11 Thread Nishanth Aravamudan
On 11.11.2015 [12:41:26 +1100], David Gibson wrote: > On Tue, Nov 10, 2015 at 04:56:38PM -0800, Nishanth Aravamudan wrote: > > On 11.11.2015 [11:17:58 +1100], David Gibson wrote: > > > On Mon, Nov 09, 2015 at 08:22:32PM -0800, Sukadev Bhattiprolu wrote: > > > The trouble with xscom is that it's

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-10 Thread Sukadev Bhattiprolu
Alexey Kardashevskiy [a...@ozlabs.ru] wrote: | | | No, you do not try reading "ibm,chip-id" if there is no "xscom@" | under /proc/device-tree, there is "continue": | | +if (strncmp(xscom_prefix, ent->d_name, strlen(xscom_prefix))) { | +continue; | +} | Ah, yes,

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-10 Thread David Gibson
On Mon, Nov 09, 2015 at 08:22:32PM -0800, Sukadev Bhattiprolu wrote: > David Gibson [da...@gibson.dropbear.id.au] wrote: > | On Wed, Nov 04, 2015 at 03:06:05PM -0800, Sukadev Bhattiprolu wrote: > | > Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to > rtas_get_sysparm() > | > call in

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-10 Thread Thomas Huth
On 10/11/15 05:22, Sukadev Bhattiprolu wrote: [...] > | > +static int file_read_buf(char *file_name, char *buf, int len) > | > +{ > | > +int rc; > | > +FILE *fp; > | > + > | > +fp = fopen(file_name, "r"); > | > +if (!fp) { > | > +error_report("%s: Error opening %s\n",

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-10 Thread Nishanth Aravamudan
On 11.11.2015 [11:17:58 +1100], David Gibson wrote: > On Mon, Nov 09, 2015 at 08:22:32PM -0800, Sukadev Bhattiprolu wrote: > > David Gibson [da...@gibson.dropbear.id.au] wrote: > > | On Wed, Nov 04, 2015 at 03:06:05PM -0800, Sukadev Bhattiprolu wrote: > > | > Implement

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-10 Thread David Gibson
On Tue, Nov 10, 2015 at 04:56:38PM -0800, Nishanth Aravamudan wrote: > On 11.11.2015 [11:17:58 +1100], David Gibson wrote: > > On Mon, Nov 09, 2015 at 08:22:32PM -0800, Sukadev Bhattiprolu wrote: > > > David Gibson [da...@gibson.dropbear.id.au] wrote: > > > | On Wed, Nov 04, 2015 at 03:06:05PM

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-09 Thread Alexey Kardashevskiy
On 11/10/2015 02:57 PM, Sukadev Bhattiprolu wrote: Alexey Kardashevskiy [a...@ozlabs.ru] wrote: | On 11/05/2015 10:06 AM, Sukadev Bhattiprolu wrote: | >Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() | >call in qemu. This call returns the processor module (socket),

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-09 Thread Sukadev Bhattiprolu
Alexey Kardashevskiy [a...@ozlabs.ru] wrote: | >| When exactly does a socket become a module? The SPAPR spec uses "sockets" here. | > | >I am trying to get the terminology too :-) Is socket a slot where a | >module is attached? | | Sorry, no idea. Ok. | | | > | >I will change the variable

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-09 Thread Sukadev Bhattiprolu
Alexey Kardashevskiy [a...@ozlabs.ru] wrote: | On 11/05/2015 10:06 AM, Sukadev Bhattiprolu wrote: | >Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() | >call in qemu. This call returns the processor module (socket), chip and core | >information as specified in section

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-09 Thread Sukadev Bhattiprolu
David Gibson [da...@gibson.dropbear.id.au] wrote: | On Wed, Nov 04, 2015 at 03:06:05PM -0800, Sukadev Bhattiprolu wrote: | > Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() | > call in qemu. This call returns the processor module (socket), chip and core | > information

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-09 Thread Alexey Kardashevskiy
On 11/10/2015 03:46 PM, Sukadev Bhattiprolu wrote: Alexey Kardashevskiy [a...@ozlabs.ru] wrote: | >| When exactly does a socket become a module? The SPAPR spec uses "sockets" here. | > | >I am trying to get the terminology too :-) Is socket a slot where a | >module is attached? | | Sorry, no

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-08 Thread Alexey Kardashevskiy
On 11/05/2015 10:06 AM, Sukadev Bhattiprolu wrote: Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() call in qemu. This call returns the processor module (socket), chip and core information as specified in section 7.3.16.18 of PAPR v2.7. We walk the /proc/device-tree

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-08 Thread David Gibson
On Mon, Nov 09, 2015 at 12:57:48PM +1100, Alexey Kardashevskiy wrote: > On 11/05/2015 10:06 AM, Sukadev Bhattiprolu wrote: > >Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() > >call in qemu. This call returns the processor module (socket), chip and core > >information

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-08 Thread David Gibson
On Wed, Nov 04, 2015 at 03:06:05PM -0800, Sukadev Bhattiprolu wrote: > Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() > call in qemu. This call returns the processor module (socket), chip and core > information as specified in section 7.3.16.18 of PAPR v2.7. PAPR

[Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-04 Thread Sukadev Bhattiprolu
Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() call in qemu. This call returns the processor module (socket), chip and core information as specified in section 7.3.16.18 of PAPR v2.7. We walk the /proc/device-tree to determine the number of chips, cores and modules