Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 03:42:19PM +0800, Amos Kong wrote: > On Tue, Jun 04, 2013 at 02:43:11PM +0800, Amos Kong wrote: > > > > > > I did more tests in clear environment, and found that the guest hang/slow > > (no response from monitor) is caused by flooding events. I could not > > reproduce it

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-06-04 Thread Amos Kong
On Tue, Jun 04, 2013 at 02:43:11PM +0800, Amos Kong wrote: > > I did more tests in clear environment, and found that the guest hang/slow > (no response from monitor) is caused by flooding events. I could not > reproduce it with upstream qemu [1] > > If I set event_throttle to 1 ~ 1000, the prob

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-06-03 Thread Amos Kong
On Fri, May 31, 2013 at 11:02:54AM +0800, Amos Kong wrote: > On Fri, May 31, 2013 at 08:35:28AM +0800, Amos Kong wrote: > > On Thu, May 30, 2013 at 04:54:41PM +0300, Michael S. Tsirkin wrote: > > > On Tue, May 28, 2013 at 08:25:56AM -0400, Luiz Capitulino wrote: > > > > > > > 2. Can you actually

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-30 Thread Amos Kong
On Fri, May 31, 2013 at 08:35:28AM +0800, Amos Kong wrote: > On Thu, May 30, 2013 at 04:54:41PM +0300, Michael S. Tsirkin wrote: > > On Tue, May 28, 2013 at 08:25:56AM -0400, Luiz Capitulino wrote: > > > On Tue, 28 May 2013 06:43:04 +0800 > > > Amos Kong wrote: > > > > > > > On Mon, May 27, 2013

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-30 Thread Amos Kong
On Thu, May 30, 2013 at 04:54:41PM +0300, Michael S. Tsirkin wrote: > On Tue, May 28, 2013 at 08:25:56AM -0400, Luiz Capitulino wrote: > > On Tue, 28 May 2013 06:43:04 +0800 > > Amos Kong wrote: > > > > > On Mon, May 27, 2013 at 09:24:28AM -0400, Luiz Capitulino wrote: > > > > On Mon, 27 May 2013

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 09:50:35PM +0800, Amos Kong wrote: > On Tue, May 28, 2013 at 08:25:56AM -0400, Luiz Capitulino wrote: > > On Tue, 28 May 2013 06:43:04 +0800 > > Amos Kong wrote: > > CC: netdev, vlad > > Currently we create & open macvtap device by libvirt(management), > and pass the fd t

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-30 Thread Michael S. Tsirkin
On Tue, May 28, 2013 at 08:25:56AM -0400, Luiz Capitulino wrote: > On Tue, 28 May 2013 06:43:04 +0800 > Amos Kong wrote: > > > On Mon, May 27, 2013 at 09:24:28AM -0400, Luiz Capitulino wrote: > > > On Mon, 27 May 2013 09:10:11 -0400 > > > Luiz Capitulino wrote: > > > > > > > > We use the QMP ev

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-30 Thread Amos Kong
On Tue, May 28, 2013 at 08:25:56AM -0400, Luiz Capitulino wrote: > On Tue, 28 May 2013 06:43:04 +0800 > Amos Kong wrote: CC: netdev, vlad Currently we create & open macvtap device by libvirt(management), and pass the fd to qemu process. And macvtap works in promiscuous mode, we want to sync the

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-28 Thread Luiz Capitulino
On Tue, 28 May 2013 06:43:04 +0800 Amos Kong wrote: > On Mon, May 27, 2013 at 09:24:28AM -0400, Luiz Capitulino wrote: > > On Mon, 27 May 2013 09:10:11 -0400 > > Luiz Capitulino wrote: > > > > > > We use the QMP event to notify management about the mac changing. > > > > > > > > In this thread,

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-27 Thread Amos Kong
On Mon, May 27, 2013 at 09:24:28AM -0400, Luiz Capitulino wrote: > On Mon, 27 May 2013 09:10:11 -0400 > Luiz Capitulino wrote: > > > > We use the QMP event to notify management about the mac changing. > > > > > > In this thread, we _wrongly_ considered to use qmp approach to delay > > > the even

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-27 Thread Luiz Capitulino
On Mon, 27 May 2013 09:10:11 -0400 Luiz Capitulino wrote: > > We use the QMP event to notify management about the mac changing. > > > > In this thread, we _wrongly_ considered to use qmp approach to delay > > the event for avoiding the flooding. > > > > eg: monitor_protocol_event_throttle(NIC

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-27 Thread Luiz Capitulino
On Mon, 27 May 2013 17:34:25 +0800 Amos Kong wrote: > On Fri, May 24, 2013 at 08:51:36AM -0400, Luiz Capitulino wrote: > > On Fri, 24 May 2013 15:10:16 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, May 23, 2013 at 01:26:33PM -0400, Luiz Capitulino wrote: > > > > On Thu, 23 May 2013 20

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-27 Thread Amos Kong
On Fri, May 24, 2013 at 08:51:36AM -0400, Luiz Capitulino wrote: > On Fri, 24 May 2013 15:10:16 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, May 23, 2013 at 01:26:33PM -0400, Luiz Capitulino wrote: > > > On Thu, 23 May 2013 20:18:34 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 15:10:16 +0300 "Michael S. Tsirkin" wrote: > On Thu, May 23, 2013 at 01:26:33PM -0400, Luiz Capitulino wrote: > > On Thu, 23 May 2013 20:18:34 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote: > > > > On Thu, 16

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-24 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 01:26:33PM -0400, Luiz Capitulino wrote: > On Thu, 23 May 2013 20:18:34 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote: > > > On Thu, 16 May 2013 18:17:23 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > > T

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 20:18:34 +0300 "Michael S. Tsirkin" wrote: > On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote: > > On Thu, 16 May 2013 18:17:23 +0300 > > "Michael S. Tsirkin" wrote: > > > > > > The > > > > existing throttling approach ensures that if the event includes latest

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-23 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote: > On Thu, 16 May 2013 18:17:23 +0300 > "Michael S. Tsirkin" wrote: > > > > The > > > existing throttling approach ensures that if the event includes latest > > > guest information, then the host doesn't even have to do do a query, a

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 16 May 2013 18:17:23 +0300 "Michael S. Tsirkin" wrote: > > The > > existing throttling approach ensures that if the event includes latest > > guest information, then the host doesn't even have to do do a query, and > > is guaranteed that reacting to the final event will always see the mos

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-22 Thread Amos Kong
On Tue, May 21, 2013 at 11:51:17AM +0300, Michael S. Tsirkin wrote: > On Tue, May 21, 2013 at 01:04:55PM +0800, Amos Kong wrote: > > > > > > > > +event_data = qobject_from_jsonf("{ 'name': %s }", > > > > n->netclient_name); > > > > +monitor_protocol_event(QEVENT_MAC_TABLE_CHANGED, even

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-21 Thread Michael S. Tsirkin
On Tue, May 21, 2013 at 01:04:55PM +0800, Amos Kong wrote: > On Thu, May 16, 2013 at 03:17:45PM +0300, Michael S. Tsirkin wrote: > > On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > > > Introduce this new QMP event to notify management after guest changes > > > mac-table configuration.

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-20 Thread Amos Kong
On Thu, May 16, 2013 at 03:17:45PM +0300, Michael S. Tsirkin wrote: > On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > > Introduce this new QMP event to notify management after guest changes > > mac-table configuration. > > +event_data = qobject_from_jsonf("{ 'name': %s }", n->net

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Eric Blake
On 05/16/2013 09:17 AM, Michael S. Tsirkin wrote: >> The >> existing throttling approach ensures that if the event includes latest >> guest information, then the host doesn't even have to do do a query, and >> is guaranteed that reacting to the final event will always see the most >> recent reques

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 09:12:36AM -0600, Eric Blake wrote: > On 05/16/2013 09:03 AM, Michael S. Tsirkin wrote: > > On Thu, May 16, 2013 at 08:58:38AM -0600, Eric Blake wrote: > >> On 05/16/2013 06:17 AM, Michael S. Tsirkin wrote: > >>> On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > >

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Eric Blake
On 05/16/2013 09:03 AM, Michael S. Tsirkin wrote: > On Thu, May 16, 2013 at 08:58:38AM -0600, Eric Blake wrote: >> On 05/16/2013 06:17 AM, Michael S. Tsirkin wrote: >>> On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: Introduce this new QMP event to notify management after guest chan

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 06:03:26PM +0300, Michael S. Tsirkin wrote: > On Thu, May 16, 2013 at 08:58:38AM -0600, Eric Blake wrote: > > On 05/16/2013 06:17 AM, Michael S. Tsirkin wrote: > > > On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > > >> Introduce this new QMP event to notify mana

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 08:58:38AM -0600, Eric Blake wrote: > On 05/16/2013 06:17 AM, Michael S. Tsirkin wrote: > > On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > >> Introduce this new QMP event to notify management after guest changes > >> mac-table configuration. > >> > > > > This

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 08:56:42AM -0600, Eric Blake wrote: > On 05/16/2013 05:07 AM, Amos Kong wrote: > > Introduce this new QMP event to notify management after guest changes > > mac-table configuration. > > > > Signed-off-by: Amos Kong > > --- > > QMP/qmp-events.txt| 14 ++

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Eric Blake
On 05/16/2013 06:17 AM, Michael S. Tsirkin wrote: > On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: >> Introduce this new QMP event to notify management after guest changes >> mac-table configuration. >> > > This makes it easy for guest to flood management with > spurious events. > How

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Eric Blake
On 05/16/2013 05:07 AM, Amos Kong wrote: > Introduce this new QMP event to notify management after guest changes > mac-table configuration. > > Signed-off-by: Amos Kong > --- > QMP/qmp-events.txt| 14 ++ > hw/net/virtio-net.c | 12 > include/monitor/monitor

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Luiz Capitulino
On Thu, 16 May 2013 15:45:17 +0300 "Michael S. Tsirkin" wrote: > On Thu, May 16, 2013 at 08:24:03AM -0400, Luiz Capitulino wrote: > > On Thu, 16 May 2013 15:17:45 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > > > > Introduce this ne

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 08:24:03AM -0400, Luiz Capitulino wrote: > On Thu, 16 May 2013 15:17:45 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > > > Introduce this new QMP event to notify management after guest changes > > > mac-table configur

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Luiz Capitulino
On Thu, 16 May 2013 15:17:45 +0300 "Michael S. Tsirkin" wrote: > On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > > Introduce this new QMP event to notify management after guest changes > > mac-table configuration. > > > > Signed-off-by: Amos Kong > > --- > > QMP/qmp-events.txt

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > Introduce this new QMP event to notify management after guest changes > mac-table configuration. > > Signed-off-by: Amos Kong > --- > QMP/qmp-events.txt| 14 ++ > hw/net/virtio-net.c | 12 > inclu

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 07:07:24PM +0800, Amos Kong wrote: > Introduce this new QMP event to notify management after guest changes > mac-table configuration. > > Signed-off-by: Amos Kong > --- > QMP/qmp-events.txt| 14 ++ > hw/net/virtio-net.c | 12 > inclu

[Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-16 Thread Amos Kong
Introduce this new QMP event to notify management after guest changes mac-table configuration. Signed-off-by: Amos Kong --- QMP/qmp-events.txt| 14 ++ hw/net/virtio-net.c | 12 include/monitor/monitor.h | 1 + monitor.c | 1 + 4 files chan