Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Markus Armbruster
Jason Baron writes: > On Thu, Dec 20, 2012 at 08:07:02PM +, Blue Swirl wrote: >> On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: >> > From: Jason Baron [...] >> > @@ -172,9 +173,11 @@ void qtest_quit(QTestState *s) >> > unlink(s->pid_file); >> > unlink(s->socket_path); >> >

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Blue Swirl
On Thu, Dec 20, 2012 at 8:26 PM, Jason Baron wrote: > On Thu, Dec 20, 2012 at 08:07:02PM +, Blue Swirl wrote: >> On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: >> > From: Jason Baron >> > >> > Currently, the qtest harness can only spawn 1 qemu instance at a time >> > because >> > the p

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Jason Baron
On Thu, Dec 20, 2012 at 08:07:02PM +, Blue Swirl wrote: > On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: > > From: Jason Baron > > > > Currently, the qtest harness can only spawn 1 qemu instance at a time > > because > > the parent pid is used to create the socket files. Use 'mkdtemp()'

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Blue Swirl
On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: > From: Jason Baron > > Currently, the qtest harness can only spawn 1 qemu instance at a time because > the parent pid is used to create the socket files. Use 'mkdtemp()' in But mkdtemp() is not available on Win32. > combination with the paren

[Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Jason Baron
From: Jason Baron Currently, the qtest harness can only spawn 1 qemu instance at a time because the parent pid is used to create the socket files. Use 'mkdtemp()' in combination with the parent pid to avoid conflicts. Signed-off-by: Jason Baron --- tests/libqtest.c | 15 +-- 1 fi