Re: [Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open

2013-08-19 Thread Kevin Wolf
Am 13.08.2013 um 03:21 hat Fam Zheng geschrieben: > VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the > value. This patch honors the header field. > > And the L2 table size is 4096 according to VMDK spec[1], instead of > 1 << 9 (512). > > [1]: > http://www.vmware.com/suppor

Re: [Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open

2013-08-19 Thread Paolo Bonzini
Il 19/08/2013 04:18, Fam Zheng ha scritto: > On Sun, 08/18 17:19, Paolo Bonzini wrote: >> Il 13/08/2013 03:21, Fam Zheng ha scritto: >>> VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the >>> value. This patch honors the header field. >>> >>> And the L2 table size is 4096 acco

Re: [Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open

2013-08-18 Thread Fam Zheng
On Sun, 08/18 17:19, Paolo Bonzini wrote: > Il 13/08/2013 03:21, Fam Zheng ha scritto: > > VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the > > value. This patch honors the header field. > > > > And the L2 table size is 4096 according to VMDK spec[1], instead of > > 1 << 9

Re: [Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open

2013-08-18 Thread Paolo Bonzini
Il 13/08/2013 03:21, Fam Zheng ha scritto: > VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the > value. This patch honors the header field. > > And the L2 table size is 4096 according to VMDK spec[1], instead of > 1 << 9 (512). I'm not sure from the VMDK spec that _only_ 40

[Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open

2013-08-12 Thread Fam Zheng
VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the value. This patch honors the header field. And the L2 table size is 4096 according to VMDK spec[1], instead of 1 << 9 (512). [1]: http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk Signed-off-by: Fam